focus-ios icon indicating copy to clipboard operation
focus-ios copied to clipboard

"Add to reading list" button is displayed in long press context menu

Open SimonBasca opened this issue 3 years ago • 2 comments

Steps to reproduce

  1. Type "Test" and do a google search
  2. Long press on a google search result
  3. Observe the "Add to reading list" button

Expected behavior

  • My opinion is we should remove this item from the context menu or we should properly support it

Actual behavior

  • The button is displayed although we don't have a reading list for Focus. The item will be added to Reading list in Safari after tapping on it. Note that the "Add to reading list" button is displayed despite the page does not have reader mode.

Device & build information

  • Device: iPhone 12 Pro (15.1)
  • Build version: 9000 (9489)

Notes

Attachments:

https://user-images.githubusercontent.com/32130829/143212835-809f1612-efc9-4fe8-9d86-f446cc4af880.mp4

SimonBasca avatar Nov 24 '21 09:11 SimonBasca

I removed the Bug label because I am not sure if this is a bug.

It would be nice to find out if we can add additional items to this menu - and then maybe if Pocket is installed, include an "Add to Pocket" item?

st3fan avatar Nov 24 '21 15:11 st3fan

There are no plans to support a reading list, we should remove this item from the context menu since it creates false user expectation of a reading list support.

rtestard avatar Sep 12 '22 11:09 rtestard

Fixed in #3523

razvanlitianu avatar Oct 19 '22 08:10 razvanlitianu

Verified as fixed on v9000 (15188) with iPhone 13 Pro (15.1.1).

abodea avatar Nov 01 '22 13:11 abodea