focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Switch Tabs Using Toolbar Swipe Gesture

Open 4shutosh opened this issue 3 years ago • 4 comments

Pull Request checklist

Fixes #7730

  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • [x] QA Needed

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to build-focus-debug or build-klar-debug for changes targeting Klar,
  3. click View task in Taskcluster,
  4. click the Artifacts row,
  5. click to download any of the apks listed here which use an appropriate name for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

4shutosh avatar Sep 25 '22 11:09 4shutosh

No Taskcluster jobs started for this pull request 

The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

firefoxci-taskcluster[bot] avatar Sep 25 '22 11:09 firefoxci-taskcluster[bot]

I use focus daily while reading blogs and surfing through websites. I did the changes required for the swipe behavior, primarily for my use case. I understand this does not follow the ideal contribution guidelines.

Please let me know if anything else is required. More than happy to do the changes and do the necessary for the good.

4shutosh avatar Sep 25 '22 11:09 4shutosh

Most of the pieces of code are referred and used from fenix.

The introduced behaviour is as follows:

https://user-images.githubusercontent.com/53831987/192141418-b4b76f88-3d71-413a-aff5-3b47c9839341.mp4

4shutosh avatar Sep 25 '22 11:09 4shutosh

Thank you for looking into this but such a change should be first discussed with Product and UX. We will bring this up. Some engineering investigation is also needed to check whether this functionality should be uplifted to A-C and then shared by both projects instead of duplicating the code.

Mugurell avatar Sep 26 '22 06:09 Mugurell

We are not gonna land this pr , a decision was made by @rtestard . Too much risk of confusion with the back action and lack of alignment with what users coming from Chrome . Thank you very much @4shutosh .

iorgamgabriel avatar Oct 25 '22 14:10 iorgamgabriel

Too much risk of confusion with the back action and lack of alignment with what users coming from Chrome .

@rtestard @iorgamgabriel I don't understand the argument with Chrome. The gesture is implemented in Firefox for Android as well as in Google Chrome, Samsung Internet and other browsers for Android. If anything causes confusion for Focus users, then that a gesture that is well known from most other browsers, including Firefox, is not implemented in Focus, no? What am I missing? 🤔

cadeyrn avatar Oct 25 '22 15:10 cadeyrn

Thank you for considering 🙌🏻

I agree with @cadeyrn, the main reason to implement this was my muscle memory being disrespected on Focus

4shutosh avatar Oct 25 '22 15:10 4shutosh