focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard

Move startup perf measurements to a background thread

Open badboy opened this issue 3 years ago • 3 comments

Similar fix as done on Fenix: https://github.com/mozilla-mobile/fenix/pull/26165 Should avoid loading the Glean core library too early, but still records the data just fine.

Note that Focus doesn't record startup time, so nothing to delay there.

Fixes #7216


I haven't run that locally yet, so I'm not 100% sure if it addresses it all.

Pull Request checklist

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • [x] QA Needed

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to build-focus-debug or build-klar-debug for changes targeting Klar,
  3. click View task in Taskcluster,
  4. click the Artifacts row,
  5. click to download any of the apks listed here which use an appropriate name for each CPU architecture.

GitHub Automation

Fixes #7216

badboy avatar Aug 09 '22 14:08 badboy

Ok, the test fails so I need to look into this.

badboy avatar Aug 10 '22 10:08 badboy

It doesn't fail for me locally.

badboy avatar Aug 10 '22 11:08 badboy

See https://github.com/mozilla-mobile/fenix/pull/26544 for the Fenix fix for the tests.

mcarare avatar Aug 19 '22 13:08 mcarare

Rebased and applied the same fix that Fenix did

badboy avatar Oct 25 '22 12:10 badboy