focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard

The "Remove" option from a shortcut is overlapping the shortcut when the keyboard is triggered

Open lobontiumira opened this issue 4 years ago • 10 comments
trafficstars

Steps to reproduce

  1. Install Focus v93.
  2. Add a shortcut to the homescreen.
  3. Go to the homescreen, and activate the keyboard.
  4. Long-tap on the shortcut, and observe the position of the "Remove" option.

Expected behavior

The "Remove" option is below the shortcut even when the keyboard is triggered.

Actual behavior

The "Remove" option from a shortcut is overlapping the shortcut when the keyboard is triggered.

Device information

  • Android device: Sony Xperia Z5 Premium (Android 7.1.1), Huawei P9 Lite (Android 8)
  • Focus version: 93.1.0 RC build, and on the latest debug build from main from 9/30
  • Not reproducible on Samsung Galaxy Note 8 (Android 9), on Samsung Galaxy Tab A6 (Android 5.1.1), nor on Xiaomi mi4i (Android 5.0.2)

https://user-images.githubusercontent.com/40694158/135421375-d74ffe28-0c4d-4557-bc73-6765a8dbd08f.mp4

lobontiumira avatar Sep 30 '21 09:09 lobontiumira

This is still reproducible on RC 93.1.1 with the same devices: Sony Xperia Z5 Premium (Android 7.1.1), Huawei P9 Lite (Android 8).

lobontiumira avatar Oct 01 '21 13:10 lobontiumira

The issue is still present on Beta 94.0.0-beta.2 (build 352922038 GV 94.0-20211017185800) and the latest debug build from main 10/20 with Huawei P9 Lite (Android 8).

delia-pop avatar Oct 20 '21 09:10 delia-pop

Still reproducible on Sony Xperia Z5 Premium (Android 7.1.1) on the latest Focus Nightly 95.0 (build 353061431 GV 95.0a1-20211101084651).

lobontiumira avatar Nov 02 '21 12:11 lobontiumira

Reproducible on Beta 97.0.0-beta.5 with LG G7 fit (Android 8.1.0). The "Rename/Remove" option menu is displayed for a split second above the shortcut when tapped from the awesome bar.

https://user-images.githubusercontent.com/89388888/151154922-de20cca3-9e89-481d-bc39-f31b5d07cfc7.mp4

delia-pop avatar Jan 26 '22 11:01 delia-pop

This issue still reproduces on all Focus builds (Nightly 102.0a1 from 5/26, Beta 101.0.0-beta.6, and RC 101.1.0) with Sony Xperia Z5 Premium (Android 7.1.1). Not reproducible on Oppo Reno 6 (Android 12).

lobontiumira avatar May 26 '22 07:05 lobontiumira

@lobontiumira Can you please check if you can reproduce it? I didn't succeed on my side

ionutbedregeanu avatar Aug 10 '22 14:08 ionutbedregeanu

@ionutbedregeanu this issue still reproduces on the latest Focus nightly 105.0a1 from 8/11 with Sony Xperia Z5 Premium (Android 7.1.1):

Untitled

lobontiumira avatar Aug 11 '22 07:08 lobontiumira

I succeed to reproduce it on my side on small devices, but compose DropdownMenu behaves by default like this when it doesn't have space to be extended, so I don't see how can I improve this. Maybe the UX team(@jeffreygee ) can help us with a solution

ionutbedregeanu avatar Aug 16 '22 10:08 ionutbedregeanu

This issue still reproduces on the latest Focus nightly 107.0a1 from 10/6, and Beta 106.0b4, with Sony Xperia Z5 Premium (Android 7.1.1):

Untitled

lobontiumira avatar Oct 06 '22 07:10 lobontiumira

@lobontiumira I noticed this happens on Fenix too. The only suggestion I'd have to get around this is that we add an 'Open Shortcut' option to the menu.

cc: @rtestard any thoughts on this?

jeffreygee avatar Oct 11 '22 23:10 jeffreygee

On the screenshots it seems to have space to be extended though? I cannot reproduce on my pixel 4a and it's unclear under which circumstances it reproduces - certain screen sizes?

rtestard avatar Oct 12 '22 09:10 rtestard

@rtestard we were able to reproduce this only on:

  • Sony Xperia Z5 Premium (Android 7.1.1) that has these characteristics: 2160 x 3840 pixels, 16:9 ratio (~806 ppi density), and
  • Huawei P9 Lite (Android 7): 1080 x 1920 pixels (~432 ppi pixel density).

lobontiumira avatar Oct 12 '22 12:10 lobontiumira

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802250

Change performed by the Move to Bugzilla add-on.

cpeterso avatar Nov 24 '22 00:11 cpeterso