focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard
verified publisher icon mozilla-mobile

Force RTL is not applied to context menus

Open sflorean opened this issue 4 years ago • 4 comments

Steps to reproduce

  1. Go to developer Options and enable "Force RTL layout direction".
  2. Open Focus and go to cnn.com.
  3. Long tap on a link.
  4. Check the text and layout of the Context Menu.

Expected behavior

The layout of the Context menu is Right to left.

Actual behavior

The layout of the device is Left to Right.

Device information

  • Android device: Pixel 3 (Android 12).
  • Focus version: 93.0.2.

sflorean avatar Sep 14 '21 13:09 sflorean

Does this also happen with RTL languages? Or only when using Force RTL layout direction?

mcarare avatar Sep 14 '21 13:09 mcarare

Does this also happen with RTL languages? Or only when using Force RTL layout direction?

This is not reproducible with RTL languages, only with Force RTL.

sflorean avatar Sep 14 '21 13:09 sflorean

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 13 '22 01:04 stale[bot]

I will re-open this issue because I was able to reproduce it on the latest Focus Nightly build 101.0a1 from 4/28 with Oppo Reno 6 (Android 12), and Samsung Galaxy Note 8 (Android 9).

lobontiumira avatar Apr 28 '22 09:04 lobontiumira

can I work on this issue, I am a beginner at Opensource with Android Dev experience in Kotlin.

AyushUnleashed avatar Nov 14 '22 18:11 AyushUnleashed

can I work on this issue, I am a beginner at Opensource with Android Dev experience in Kotlin.

Would be great to! Thank you!

Mugurell avatar Nov 15 '22 06:11 Mugurell

Sorry for not responding timely, I was not able to set it up locally, today, I'll try my best to do so & reply back.

AyushUnleashed avatar Nov 22 '22 01:11 AyushUnleashed

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802660

Change performed by the Move to Bugzilla add-on.

cpeterso avatar Nov 26 '22 06:11 cpeterso

@AyushUnleashed Sorry to complicate your work on this bug, but the Focus team is moving the Focus Android code from this GitHub repo to https://github.com/mozilla-mobile/firefox-android and moving the Focus bug tracking to Bugzilla. This GitHub bug is now tracked in Bugzilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=1802660. You will need to clone and build Focus from the new repo and create a Bugzilla account.

cpeterso avatar Nov 26 '22 06:11 cpeterso