focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Find in page : The number of results doesn't get cleared when search field is cleared

Open shubhamkumar1739 opened this issue 5 years ago • 13 comments

Steps to reproduce

Search for some text in "Find in page" -> Clear search text

Expected behavior

The number of matches being zero for blank text, the text field indicating number of matches must be zero

Actual behavior

It indicates the previous number of matches

Device information

  • Android device: Redmi Note 4
  • Focus version: 8.0.22 Screenshot_2019-10-07-16-41-54-957_org mozilla focus debug

shubhamkumar1739 avatar Oct 07 '19 11:10 shubhamkumar1739

I wish to work on this

shubhamkumar1739 avatar Oct 07 '19 11:10 shubhamkumar1739

I was able to reproduce this issue by following these STR:

  1. Open a page with a lot of text.
  2. From the three-dot menu, select the "Find in page" option.
  3. Without enterring any characters, tap the up/down arrows from the "Find in page" search field.

Tested with Lenovo tab M10 (Android 10), on RC 91.2.2 build 352310216.

lobontiumira avatar Aug 19 '21 11:08 lobontiumira

Reproducible also on 93.0.2 (build 352522329 - GV 93.0a1-20210906031657) with Lenovo Tab M10 (Android 10).

lobontiumira avatar Sep 10 '21 12:09 lobontiumira

Reproducible on RC 93.1.0 with Lenovo Tab M10 (Android 10).

lobontiumira avatar Sep 29 '21 11:09 lobontiumira

The issue is still present on Beta 94.0.0-beta.2 (build 352922038 GV 94.0-20211017185800) and the latest debug build from main 10/20 with Huawei P9 Lite (Android 8).

delia-pop avatar Oct 20 '21 13:10 delia-pop

Reproducible on Beta 100.0.0-beta.1 with Lenovo Tab M10 (Android 10).

lobontiumira avatar Apr 05 '22 07:04 lobontiumira

Reproducible on Beta 101.0.0-beta.1 with Oppo Reno 6 (Android 12).

lobontiumira avatar May 03 '22 14:05 lobontiumira

Reproducible on Beta 102.0.0-beta.1 with Samsung Galaxy Tab A6 (Android 5.1.1).

lobontiumira avatar May 31 '22 07:05 lobontiumira

Reproducible on Beta 103.0.0-beta.1 with Lenovo tablet M10 (Android 10).

lobontiumira avatar Jun 28 '22 07:06 lobontiumira

Reproducible on Beta 104.0b1 with Lenovo tablet M10 (Android 10).

lobontiumira avatar Jul 26 '22 08:07 lobontiumira

Note: This is also reproducible in Fenix

ionutbedregeanu avatar Aug 11 '22 05:08 ionutbedregeanu

Note: This is also reproducible in Fenix

Would the fix then be in GeckoView / A-C?

Mugurell avatar Aug 11 '22 06:08 Mugurell

yes, probably in A-C

ionutbedregeanu avatar Aug 11 '22 06:08 ionutbedregeanu

Verified as fixed on Focus Nightly 106.0a1 from 08/26 with Xiaomi 12 Pro (Android 12).

https://user-images.githubusercontent.com/89388888/186909805-528acffe-a7e9-413e-883f-f397c5029cef.mp4

delia-pop avatar Aug 26 '22 13:08 delia-pop

Verified as fixed also on Beta 106.0b1 with Oppo Reno 6 (Android 12).

lobontiumira avatar Sep 20 '22 05:09 lobontiumira