focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard

Consider implementing long press on back button to open back stack

Open mcomella opened this issue 5 years ago • 9 comments

Why/User Benefit/User Problem

Sometimes a user wants to go back in history by more than one site: this requires them to hit the back button until the page they wanted to see has been loaded. However, wobile devices can be slow and have limited bandwidth so this process can take a while and unnecessarily cost them money reloading undesired page resources.

Fennec has a feature where you can long-press the back button to open the back stack: it'd be cool to implement something similar. Here's what fennec's looks like:

screenshot_20181105-133501

See https://github.com/mozilla-mobile/android-components/issues/1275 for how we might share this code in components and https://github.com/mozilla-mobile/firefox-tv/issues/1465 for the Fire TV feature request.

@aminalhazwani What do you think of this idea?

What / Requirements

  • Implement back stack for feature: get back stack information from components and maybe wrap more things in components
  • Implement front-end: optional components help here (e.g. an adapter they can implement)

Acceptance Criteria (how do I know when I’m done?)

mcomella avatar Nov 05 '18 21:11 mcomella

We'll discuss in the Fire TV issue: https://github.com/mozilla-mobile/firefox-tv/issues/1465#issuecomment-436178447

mcomella avatar Nov 08 '18 00:11 mcomella

This would be so great! Especially for sites that manipulate history like Outlook! I can never escape Outlook.

Poopooracoocoo avatar Sep 25 '19 17:09 Poopooracoocoo

Can I take this please?

mathu97 avatar Mar 15 '20 03:03 mathu97

@mathu97 please do! Development on Focus is rather stagnant, probably because they're working on Fenix

Poopooracoocoo avatar Mar 17 '20 01:03 Poopooracoocoo

@mathu97 Unfortunately, I don't believe we're actively reviewing pull requests on focus right now so I'd suggest not taking this issue if your goal is to merge the code into master – Poopooracoocoo is correct in that we're focusing on Fenix right now. I'll note there are many contribution opportunities there.

mcomella avatar Mar 20 '20 00:03 mcomella

@jonalmeida is this coming to Focus? :3

Poopooracoocoo avatar Sep 30 '21 20:09 Poopooracoocoo

@Poopooracoocoo it isn't planned, but if you'd like to put up a patch (similar to how it works in Fenix), we'd definitely accept it!

jonalmeida avatar Sep 30 '21 21:09 jonalmeida

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 13 '22 01:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity.

It would still be a nice feature for Focus, so let's keep this open.

cadeyrn avatar Apr 13 '22 06:04 cadeyrn

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802039

Change performed by the Move to Bugzilla add-on.

csadilek avatar Nov 22 '22 23:11 csadilek