firefox-ios
firefox-ios copied to clipboard
mozilla-mobile
#8897 - Move to UISceneDelegate
Fixes #8897, #9138.
This may be more than required for an initial implementation, but it is what I've been using in my personal builds for a while.
Opening as draft for initial review.
This pull request has conflicts when rebasing. Could you fix it @q2r5?
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Prelim look at this is great. I still haven't pulled and poked around that way, yet. But so far so good. :)
Great work @q2r5
This pull request has conflicts when rebasing. Could you fix it @q2r5?
This pull request has conflicts when rebasing. Could you fix it @q2r5?
This pull request has conflicts when rebasing. Could you fix it @q2r5?
This pull request has conflicts when rebasing. Could you fix it @q2r5?
Hey @q2r5 ! Thanks for keeping this up to date. We're currently working on a major release, and as this PR has potential to be a little more risky we would look into reviewing this PR after v106 soft freeze (in a couple of weeks). Feel free to ping us if this falls under the radar again, as this is good work and we should merge this!
This pull request has conflicts when rebasing. Could you fix it @q2r5?
This pull request has conflicts when rebasing. Could you fix it @q2r5?
This pull request has conflicts when rebasing. Could you fix it @q2r5?
This pull request has conflicts when rebasing. Could you fix it @q2r5?
@q2r5 Hello! Just a quick update, @nishant2718 is looking into everything relating to scenes changes (including work from PR https://github.com/mozilla-mobile/firefox-ios/pull/11308). He'll give you some insights on his research pretty soon. Thank you for your understanding!
👋 @q2r5 ! It's time to explain the silence.
I really want to thank you for raising this PR! This is excellent work and we always look forward to seeing your contributions. There's a lot of great stuff here and we seriously discussed how we can merge it, but we had to take a look at the bigger picture first.
The transition to Scenes is a risky task. We're taking it slow because we've identified quite a few things that needed to happen leading up to being able to work on this, like:
- IDing some initial blockers, like the usage of
foregroundBVC() - handling our dependencies reasonably (we're slowly adopting a container based strategy with Dip)
- Isolating window / view setup that's within AppDelegate
- much more
We try giving context where we can, but sometimes it's a bit difficult to convey. And that's why it took a while to respond here. I hope this helps in understanding the journey to a Scened app and eventually, multiple window support :)
Again, we really appreciate your work and all your contributions, and you'll definitely be listed as a co-author for the work! Catch you on the next one 😄
For a reference, here's the PR we're working with now to make that transition to a single scene app (pre-multi window support).