Below address bar search suggestions unreachable via keyboard

[ChaiTRex]

Steps to reproduce

1. Type the start of a search query
2. See the search term you want to use in the suggestions below the address bar
3. Press the down key on the keyboard
4. See that the search suggestions are completely skipped
5. Press the up key on the keyboard
6. See that the search suggestions are completely unreachable via keyboard

Expected behavior

Pressing down while in the address bar goes to the search suggestions.

Actual behavior

Pressing down while in the address bar skips over the search suggestions. Pressing up below the search suggestions cannot reach the search suggestions.

Device & build information

• Device: iPad Air 2 celliular
• Build version: Firefox Daylight 34.2 (5301)
  1. Notes Attachments: Video demonstration

https://user-images.githubusercontent.com/23159282/123729460-fee8db00-d862-11eb-90a7-db37cf7d6563.MP4

┆Issue is synchronized with this Jira Task

[github-actions[bot]]

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

[ChaiTRex]

The issue is still present in Firefox 115.0 (32242) on iOS 16.5.1. It skips past my selected search engine's suggestions at the top of the under-address-bar list to the Firefox Suggest section.

[github-actions[bot]]

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

[data-sync-user]

➤ Matt Reagan commented:

Note: it looks like support for this has been added, though it is only enabled if the toolbar refactor is enabled. However, even if I ensure that the related flags are enabled I don’t get the expected behavior from the up/down arrows. At a glance it looks like SearchViewController.handleKeyCommands always returns early in the initial guard. Needs some additional investigation.

See BrowserViewController.keyCommands

[data-sync-user]

➤ Andrei Bodea commented:

Verified as fixed on v129 (43869) iPad Pro (16.4.1).