firefox-ios
firefox-ios copied to clipboard
Bugfix FXIOS-12769 [Jump Back In] JBI section not showing when expected
:scroll: Tickets
:bulb: Description
- Shows the jump back in homepage section when recently accessed tabs are available in the following scenarios:
- On app launch
- When the "+" toolbar button is tapped
- When opening a new tab via toolbar swipe gesture
- When opening a shortcut/story/bookmark in a new tab via context menu
:pencil: Checklist
- [x] I filled in the ticket numbers and a description of my work
- [x] I updated the PR name to follow our PR naming guidelines
- [ ] I ensured unit tests pass and wrote tests for new code
- [ ] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
- [ ] If adding telemetry, I read the data stewardship requirements and will request a data review
- [ ] If adding or modifying strings, I read the guidelines and will request a string review from l10n
- [ ] If needed, I updated documentation and added comments to complex code
| Messages | |
|---|---|
| :book: | Project coverage: 37.19% |
๐ช Quality guardian
1 tests files modified. You're a champion of test coverage! ๐
๐งน Tidy commit
Just 4 file(s) touched. Thanks for keeping it clean and review-friendly!
โ Per-file test coverage gate
The following changed file(s) are below 35.0% coverage:
| File | Coverage | Required |
|---|---|---|
firefox-ios/Client/Frontend/Browser/Tabs/Middleware/TabManagerMiddleware.swift |
26.6% | 35.0% |
Client.app: Coverage: 37.1
| File | Coverage | |
|---|---|---|
| TabManagerAction.swift | 100.0% | โ |
| TabManagerMiddleware.swift | 26.63% | โ ๏ธ |
| TabManagerImplementation.swift | 54.32% | โ |
Generated by :no_entry_sign: Danger Swift against 15506109876d7a0844b09d68e4655b954b671412