mozilla-mobile
Refactor EXP-5874 [Nimbus] Split "Run Studies" into "Feature Studies" + "Remote Improvments"
We want to separate "Run Studies" into "Feature Studies" and "Remote Improvements", to give the users more choice in either participating in studies and/or improvements. So far, if they don't participate in studies, they don't get to access experiments.
This builds on top of the underlying change in the Nimbus SDK, which was introduced in this commit: https://github.com/mozilla-mobile/firefox-ios/commit/eb2292d0325acd7f76a743c253763a0fa959e362
:scroll: Tickets
:bulb: Description
| Before | After |
|---|---|
:pencil: Checklist
- [x] I filled in the ticket numbers and a description of my work
- [ ] I updated the PR name to follow our PR naming guidelines
- [ ] I ensured unit tests pass and wrote tests for new code
- [ ] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
- [ ] If adding telemetry, I read the data stewardship requirements and will request a data review
- [ ] If adding or modifying strings, I read the guidelines and will request a string review from l10n
- [ ] If needed, I updated documentation and added comments to complex code
We can't land this until we get legal approval on the wording -- we only have UX approval so far.
In general, I'm approving the code as it looks good. But there's some issues that we need to clarify before I can we land this:
1. We are about 4 days past String Freeze, so this landing is 147 is.... uh, iffy.
We should be targeting 148
2. We're now on weekly releases, so, landing this without a feature flag will immediately propagate to users when we ship, which, with localizations, is problematic. It seems like we either want to wait for localizations (ie. land strings in a separate PR, and then land this when we want it to go live later!, or we want to throw it behind a feature flag. What's the timing needed on this?
I guess we should split strings out now and land them ASAP and then we can land this before the end of the 148.x cycle when we hopefully have strings? Desktop and Android are targeting 148 Nightly for this work.
I opened up a "Strings only" PR: https://github.com/mozilla-mobile/firefox-ios/pull/31198 @freshstrangemusic @adudenamedruby
I guess we should split strings out now and land them ASAP and then we can land this before the end of the 148.x cycle when we hopefully have strings? Desktop and Android are targeting 148 Nightly for this work.
Ok. we'll wait till it's ready to go out, then, and land it at that point.
