firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

BugFix FXIOS-28385 [Search Suggestions] Keep suggestions visible when scrolling on Custom New Tab

Open ananyashreesharma opened this issue 2 months ago โ€ข 5 comments

๐Ÿงพ Tickets

๐Ÿ“ Description

When New Tab is set to Custom, dragging the suggestions list hides the keyboard and unintentionally cancels URL bar editing, which closes the suggestions abruptly
This change skips the keyboard hide auto cancel while suggestions are visible aligning behaviour with Firefox Home/Blank.

Before

https://github.com/user-attachments/assets/c59c803a-eac8-4c96-a765-c2413375719d

After

https://github.com/user-attachments/assets/73e819d7-8864-4e5d-bc6d-c7960c1e5c0f

Test plan

  • Setup:
    • Settings โ†’ General โ†’ New Tab โ†’ Custom, URL: https://www.google.com
    • Address bar position: verify both Top and Bottom
  • Custom New Tab
    • Type โ€œfirโ€; drag/bounce suggestions โ†’ suggestions stays
    • Tap Cancel while dragging โ†’ overlay closes.
    • Tap a suggestion โ†’ loads and overlay closes.
    • Press Return โ†’ submits and closes.
    • Rotate mid-scroll; start/stop dictation โ†’ no unintended dismiss.
  • Firefox Home & Blank: drag keeps suggestions; Cancel still dismisses.
  • Private: unchanged (no suggestions until turned on manually)

โœ… Checklist

  • [x] I filled in the ticket numbers and a description of my work

  • [x] I updated the PR name to follow our PR naming guidelines

  • [ ] I ensured unit tests pass and wrote tests for new code

  • [ ] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)

  • [ ] If adding telemetry, I read the data stewardship requirements and will request a data review

  • [ ] If adding or modifying strings, I read the guidelines and will request a string review from l10n

  • [ ] If needed, I updated documentation and added comments to complex code

  • Fixes #28385

ananyashreesharma avatar Oct 23 '25 11:10 ananyashreesharma

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

github-actions[bot] avatar Nov 07 '25 00:11 github-actions[bot]

@ananyashreesharma We're currently exploring a simpler fix, and there are some internal discussions underway about the expected behavior. We're waiting on clarification, so it might take a few more days before we can move forward.

thatswinnie avatar Nov 10 '25 18:11 thatswinnie

Sure @thatswinnie & @FilippoZazzeroni. Thanks for looking into it!

ananyashreesharma avatar Nov 10 '25 18:11 ananyashreesharma

This pull request has conflicts when rebasing. Could you fix it @ananyashreesharma? ๐Ÿ™

mergify[bot] avatar Nov 19 '25 15:11 mergify[bot]

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

github-actions[bot] avatar Dec 05 '25 00:12 github-actions[bot]