firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Bugfix MTE-4691 Launching context menu on iOS 15

Open clarmso opened this issue 6 months ago • 1 comments

:scroll: Tickets

Jira ticket

:bulb: Description

ShareToolbarTests, ShareMenuTests, ShareLongPressTests fail on iOS 15 only because openNewTabAndValidateURLisPaste fails to open the context menu. https://storage.googleapis.com/mobile-reports/public/firefox-ios-M1/firefox-ios-iphone-iOS-15/result_236/firefox-ios/build/reports/index.html

A solution is to minimize the keyboard before long press on the address toolbar. This solution does not affect iOS 16, 17 and 18.

:movie_camera: Demos

Before After
Demo

:pencil: Checklist

  • [ ] I filled in the ticket numbers and a description of my work
  • [ ] I updated the PR name to follow our PR naming guidelines
  • [ ] I ensured unit tests pass and wrote tests for new code
  • [ ] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • [ ] If adding telemetry, I read the data stewardship requirements and will request a data review
  • [ ] If needed, I updated documentation and added comments to complex code
  • [ ] If needed, I added a backport comment (example @Mergifyio backport release/v120)

clarmso avatar Jun 14 '25 01:06 clarmso

Messages
:book: Edited 1 files
:book: Created 0 files

Generated by :no_entry_sign: Danger Swift against aaca75a38381740d3c41f3b3cc35b6fdfb89f0de

mobiletest-ci-bot avatar Jun 14 '25 01:06 mobiletest-ci-bot

production has been using this charset without any issues.

clarmso avatar Jun 16 '25 22:06 clarmso

Opened a new PR: https://github.com/mozilla-mobile/firefox-ios/pull/27521

clarmso avatar Jun 24 '25 02:06 clarmso