firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

[Telemetry Audit] Move old and new app menu probes to their own app_menu.yaml file

Open data-sync-user opened this issue 6 months ago • 0 comments

The Task

This task is to move the old and new versions of the app menu’s probes out of the monolithic metrics.yaml file and into their own YAML file with an AppMenu tag.

You can use the FirefoxTelemetryUtility.sh script to create a new app_menu.yaml file.

More instructions on using the script can be found in our wiki: https://github.com/mozilla-mobile/firefox-ios/wiki/Adding-Glean-Telemetry-Events-and-Metrics#a-update-the-telemetry-specification-yaml-files

You can look up these probes in the Glean dictionary as well: https://dictionary.telemetry.mozilla.org/apps/firefox_ios

Probes to Move

  • app_menu.block_images_disabled
  • app_menu.block_images_enabled
  • app_menu.close_button
  • app_menu.customize_homepage
  • app_menu.help
  • app_menu.home
  • app_menu.homepage_menu
  • app_menu.logins
  • app_menu.main_menu_option_selected
  • app_menu.menu_dismissed
  • app_menu.night_mode_disabled
  • app_menu.night_mode_enabled
  • app_menu.passwords
  • app_menu.save_menu_option_selected
  • app_menu.settings
  • app_menu.sign_into_sync
  • app_menu.site_menu
  • app_menu.tools_menu_option_selected
  • app_menu.whats_new
  • page_action_menu.copy_address
  • page_action_menu.create_new_tab
  • page_action_menu.find_in_page
  • page_action_menu.pin_to_top_sites
  • page_action_menu.remove_pinned_site
  • page_action_menu.report_site_issue
  • page_action_menu.request_desktop_site
  • page_action_menu.request_mobile_site
  • page_action_menu.send_to_device
  • page_action_menu.share_page_with
  • page_action_menu.view_downloads_panel
  • page_action_menu.view_history_panel

Note: The AppMenu tag will be automatically applied at the top of your new app_menu.yaml file created with the FirefoxTelemetryUtility.sh script.

You will need to add the AppMenu tag to the tags.yaml file. Please preserve alphabetical ordering. The description you can use is as follows: Corresponds to the app's main menu.

Example

You can see an example of this type of work in the following PR: https://github.com/mozilla-mobile/firefox-ios/pull/27083

:information_source: Reference Person

@ih-codes

┆Issue is synchronized with this Jira Task

data-sync-user avatar Jun 13 '25 19:06 data-sync-user