firefox-ios
firefox-ios copied to clipboard
Add [Swipe Tabs gesture] FXIOS-12287-12418 New tab gesture, cache homepage.
:scroll: Tickets
New tab gesture
Persist homepage controller to be able to screenshot homepage at any time.
:bulb: Description
Persist Homepage controller into view hierarchy in order to be able to screenshot homepage at any point in time. Add new tab gesture only when we are at the last right tab and not in homepage.
:movie_camera: Demos
https://github.com/user-attachments/assets/7d66ee25-15ce-40f3-9fe5-4d6145f54535
:pencil: Checklist
- [x] I filled in the ticket numbers and a description of my work
- [x] I updated the PR name to follow our PR naming guidelines
- [x] I ensured unit tests pass and wrote tests for new code
- [x] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
- [x] If adding telemetry, I read the data stewardship requirements and will request a data review
- [x] If needed, I updated documentation and added comments to complex code
- [x] If needed, I added a backport comment (example
@Mergifyio backport release/v120)
| Messages | |
|---|---|
| :book: | Project coverage: 35.95% |
| :book: | Edited 21 files |
| :book: | Created 2 files |
Client.app: Coverage: 35.5
| File | Coverage | |
|---|---|---|
| BrowserViewController.swift | 24.47% | ⚠️ |
| BrowserCoordinator.swift | 70.45% | ✅ |
| UITestAppDelegate.swift | 0.0% | ⚠️ |
| AddressToolbarContainer.swift | 43.36% | ⚠️ |
| ContentContainer.swift | 98.8% | ✅ |
| TabWebViewPreview.swift | 42.86% | ⚠️ |
| AddressBarPanGestureHandler.swift | 20.92% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against 18907b7af1e32d6e2c699a3f602d59ebce9d9360
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏
@thatswinnie yes i agree, i created another ticket to address reduce motion as we need to add a different animation for this case.
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏
@mergify backport release/v141
backport release/v141
✅ Backports have been created
- #27500 Add [Swipe Tabs gesture] FXIOS-12287-12418 New tab gesture, cache homepage. (backport #27280) has been created for branch
release/v141