firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add [Swipe Tabs gesture] FXIOS-12287-12418 New tab gesture, cache homepage.

Open FilippoZazzeroni opened this issue 5 months ago • 3 comments

:scroll: Tickets

New tab gesture

Jira ticket

Persist homepage controller to be able to screenshot homepage at any time.

Jira ticket Github issue

:bulb: Description

Persist Homepage controller into view hierarchy in order to be able to screenshot homepage at any point in time. Add new tab gesture only when we are at the last right tab and not in homepage.

:movie_camera: Demos

https://github.com/user-attachments/assets/7d66ee25-15ce-40f3-9fe5-4d6145f54535

:pencil: Checklist

  • [x] I filled in the ticket numbers and a description of my work
  • [x] I updated the PR name to follow our PR naming guidelines
  • [x] I ensured unit tests pass and wrote tests for new code
  • [x] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • [x] If adding telemetry, I read the data stewardship requirements and will request a data review
  • [x] If needed, I updated documentation and added comments to complex code
  • [x] If needed, I added a backport comment (example @Mergifyio backport release/v120)

FilippoZazzeroni avatar Jun 12 '25 12:06 FilippoZazzeroni

Messages
:book: Project coverage: 35.95%
:book: Edited 21 files
:book: Created 2 files

Client.app: Coverage: 35.5

File Coverage
BrowserViewController.swift 24.47% ⚠️
BrowserCoordinator.swift 70.45%
UITestAppDelegate.swift 0.0% ⚠️
AddressToolbarContainer.swift 43.36% ⚠️
ContentContainer.swift 98.8%
TabWebViewPreview.swift 42.86% ⚠️
AddressBarPanGestureHandler.swift 20.92% ⚠️

Generated by :no_entry_sign: Danger Swift against 18907b7af1e32d6e2c699a3f602d59ebce9d9360

mobiletest-ci-bot avatar Jun 12 '25 12:06 mobiletest-ci-bot

This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏

mergify[bot] avatar Jun 13 '25 08:06 mergify[bot]

@thatswinnie yes i agree, i created another ticket to address reduce motion as we need to add a different animation for this case.

FilippoZazzeroni avatar Jun 13 '25 11:06 FilippoZazzeroni

This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏

mergify[bot] avatar Jun 17 '25 15:06 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏

mergify[bot] avatar Jun 23 '25 07:06 mergify[bot]

@mergify backport release/v141

FilippoZazzeroni avatar Jun 23 '25 14:06 FilippoZazzeroni

backport release/v141

✅ Backports have been created

mergify[bot] avatar Jun 23 '25 14:06 mergify[bot]