firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Refactor FXIOS-12055 #26253 ⁃ Add logic to Danger to fail PR that add files without test

Open yoanarios opened this issue 5 months ago • 4 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Fix danger messaging

:pencil: Checklist

  • [x] I filled in the ticket numbers and a description of my work
  • [x] I updated the PR name to follow our PR naming guidelines
  • [x] I ensured unit tests pass and wrote tests for new code
  • [x] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • [x] If adding telemetry, I read the data stewardship requirements and will request a data review
  • [x] If needed, I updated documentation and added comments to complex code
  • [x] If needed, I added a backport comment (example @Mergifyio backport release/v120)

yoanarios avatar Jun 11 '25 16:06 yoanarios

Messages
:book: Edited 1 files
:book: Created 0 files

Generated by :no_entry_sign: Danger Swift against 4f8270f84599646703920b3ef223e6f775efdb56

mobiletest-ci-bot avatar Jun 11 '25 16:06 mobiletest-ci-bot

Managed to test locally and I've fixed the remaining issues where files with coverage were not found, it's still possible for files not to be included in XCTResult if they don't contain lines to be tested so we keeping the 2 warnings, 1 if is found with 0 coverage and another one if is not found meaning doesn't have test either

yoanarios avatar Jun 16 '25 14:06 yoanarios

Screenshot 2025-06-16 at 10 20 42 AM

yoanarios avatar Jun 16 '25 14:06 yoanarios

@yoanarios test to get mention notification

yoanarios avatar Jun 16 '25 14:06 yoanarios

Screenshot 2025-06-18 at 1 58 37 PM

yoanarios avatar Jun 18 '25 17:06 yoanarios

@cyndichin PR is ready to review 🎉

yoanarios avatar Jun 18 '25 18:06 yoanarios

thanks @yoanarios 🥳 . Seems like this has already been merge, only had some small nits. Thanks for improving this!

cyndichin avatar Jun 20 '25 11:06 cyndichin