[New Error Pages] Follow up work on replaceLocation() improvements

[data-sync-user]

As discussed in https://github.com/mozilla-mobile/firefox-ios/pull/23746 , replaceLocation function can possibly be cleaned up. With the latest changes for the error pages, webView?.replaceLocation(with: is now used in two places only in production code (let’s ignore reference to this method under the WebEngine code, this will need to be updated later on).

Questions

• Should we wait for all the error pages to be native error pages to clean this up? If yes, we can wait until clean up. If no then;
  • Can replaceLocation(with: usage under ErrorPageHelper be removed? Is this class still used?
  • Can replaceLocation(with: under LocalRequestHelper be removed? This class seems to be used for CertError and NetError (see related html pages).

┆Issue is synchronized with this Jira Task

[github-actions[bot]]

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

[data-sync-user]

➤ Cyndi Chin commented:

Let’s keep this open.