firefox-ios
firefox-ios copied to clipboard
Add FXIOS-10333 [Unified Search] Strings and accessibility labels/hints for Unified Search
:scroll: Tickets
:bulb: Description
This PR adds strings, accessibility labels, and accessibility hints as required by the Unified Search project.
There are two parts:
1) The new drop down search engine button in the toolbar
- Added a new accessibility hint since this is now a tappable element
2) The new bottom sheet / iPad popup which shows alternative search engines and can redirect the user to Settings > Search options
- Added label, accessibility label for the popup title
- Added accessibility label for the close button
- Added label, accessibility label, and accessibility hint for the Search Settings row
- No Strings.swift accessibility labels or hints for search engine rows (accessibility label to simply be the search engine's name)
Testing Notes
Enable both the toolbar refactor and the unified_search flag to see the new drop-down search engine button in the toolbar.
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120)
Hi @adudenamedruby! This is my first time adding a significant number of strings for a new project. Please let me know if I've followed the standards correctly or if you have any other suggestions (wasn't sure if my string comments are too long...).
There is also one string that is a bit different from the others because I wanted to partner a preexisting accessibility label with a new accessibility hint, so I tried to match that preexisting standard. Thanks! 🙏
| Messages | |
|---|---|
| :book: | Edited 1 files |
| :book: | Created 0 files |
Generated by :no_entry_sign: Danger Swift against 8a546eef7f0aadcccdc151bb5cbac6d75f2e9436