firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

[Looking for Feedback] Add FXIOS-10164 [Homepage] More Pocket Section Tests

Open cyndichin opened this issue 1 year ago • 1 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Added some more tests for the homepage rebuild - pocket section. These tests are currently passing, but looking for some feedback if this should be the standard of how we do tests. Feel free to leave feedback and can respond when I return!

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [x] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

cyndichin avatar Oct 18 '24 15:10 cyndichin

Messages
:book: Project coverage: 32.65%
:book: Edited 6 files
:book: Created 3 files

Client.app: Coverage: 30.48

File Coverage
PocketMiddleware.swift 100.0%
DependencyHelper.swift 0.0% ⚠️
PocketManager.swift 100.0%

Generated by :no_entry_sign: Danger Swift against 58b48cebb3cc0c2d1889b1ca09820202d6110d8b

mobiletest-ci-bot avatar Oct 18 '24 15:10 mobiletest-ci-bot

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

github-actions[bot] avatar Nov 02 '24 00:11 github-actions[bot]

Moving from draft to ready for review and will move back to draft if further work is needed to update these tests. Wanted to mainly get feedback if we should write our future tests this way.

cyndichin avatar Nov 04 '24 14:11 cyndichin