firefox-ios
firefox-ios copied to clipboard
Add FXIOS-10270 - Add visual indication of strict mode for lock icon
:scroll: Tickets
:bulb: Description
Video
https://github.com/user-attachments/assets/af493d2a-54d8-41fb-b730-eaa4bc610366
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120)
| Messages | |
|---|---|
| :book: | Project coverage: 32.0% |
| :book: | Edited 7 files |
| :book: | Created 0 files |
Client.app: Coverage: 30.52
| File | Coverage | |
|---|---|---|
| BrowserViewController.swift | 4.9% | ⚠️ |
| FirefoxTabContentBlocker.swift | 3.85% | ⚠️ |
| AddressToolbarContainerModel.swift | 33.05% | ⚠️ |
| AddressBarState.swift | 2.87% | ⚠️ |
| ToolbarAction.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against 438a2c00648ce1b22c961e561f2fe4f50354078d
When starting the app, websites that have tracking protection turned off are not displayed with the correct safelisted indicator until the website is refreshed: Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-18.at.16.51.15.mp4
Also the position of the dot looks wrong. Old toolbar
New toolbar
I used the same measurements as in the old toolbar, could it be that the lock icon is also different in size?
When starting the app, websites that have tracking protection turned off are not displayed with the correct safelisted indicator until the website is refreshed: Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-18.at.16.51.15.mp4 Also the position of the dot looks wrong. Old toolbar
New toolbar
I used the same measurements as in the old toolbar, could it be that the lock icon is also different in size?
They seem to be the same size for both toolbars (old and new).
This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

