firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Bugfix FXIOS-10295, FXIOS-10327 [Tab Tray Refactor] Fix TabTrayState redux bug and move tab close toast to the TabTrayState

Open ih-codes opened this issue 1 year ago • 0 comments

:scroll: Tickets

This fixes two issues:

Jira ticket 1 Github issue 1

Jira ticket 2 Github issue 2

:bulb: Description

This PR addresses two issues by:

  • Fixing the TabTrayState incorrectly returning the previous state instead of initializing a new state that clears transient data (e.g. showing the confirm dialogue for closing all tabs)
  • Make the toast behaviour for undoing a closed tab more predictable by moving its presentation one layer higher, from the TabDisplayView to the TabTrayViewController

This also removes the hideUndoToast action as it is no longer necessary since the redux bug was fixed (shouldn't get extra toasts now).

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

ih-codes avatar Oct 17 '24 23:10 ih-codes