firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Bugfix FXIOS-10265 [Toolbar Redesign] - Address displayed in edit mode after opening website with QR scan

Open thatswinnie opened this issue 1 year ago • 1 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Cancels edit mode if necessary before QR code scan is shown. Also includes some cleanup of unused code.

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

thatswinnie avatar Oct 17 '24 15:10 thatswinnie

Messages
:book: Project coverage: 32.65%
:book: Edited 2 files
:book: Created 0 files

Client.app: Coverage: 30.47

File Coverage
ToolbarMiddleware.swift 7.96% ⚠️

ToolbarKit: Coverage: 1.37

File Coverage
LocationView.swift 0.0% ⚠️

Generated by :no_entry_sign: Danger Swift against 2c89e6617cbb3ff28e01b72bcf81af4180c9d242

mobiletest-ci-bot avatar Oct 17 '24 15:10 mobiletest-ci-bot