firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-10164 [Homepage] Navigation for Pocket Section

Open cyndichin opened this issue 4 months ago • 4 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Background Context Discuss this PR during the team meeting and agree that this is the path we want to proceed in terms of navigation that is shared across the application. This PR originally came from a question asked in another PR. Some of the logic in that PR gets removed here.

Summary

  • Add navigation to pocket section (tapping on cells; learn more link)
  • Refactor navigation for customize homepage
  • Created new action called NavigationBrowserAction and new NavigationDestination type that is used to determine how to handle where to navigate
  • Instead of HomepageState knowing about where to navigate BrowserViewControllerState is responsible for this because the navigation is not unique to homepage
  • Added state tests, BVC is lacking tests currently so didn't test handleNavigation, the effort seems more worth to test this when we revisit cleaning up BVC.

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [x] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

Video

https://github.com/user-attachments/assets/6c53e5c6-571d-4e69-b39e-df75c55f1c70

cyndichin avatar Oct 16 '24 17:10 cyndichin