Update how we are tearing down our tests

[data-sync-user]

:page_facing_up: Description

We should update how where we call super.teardown in our unit tests. Calling the superclass teardown should be called after the clean up operations. Please make the appropriate changes in the areas where we are calling the superclass teardown first and not last in our test suites teardown methods.

:books: Resources

You can find the unit test guidelines here: https://github.com/mozilla-mobile/firefox-ios/wiki/Unit-Tests-Guidelines This ticket is specifically related to addressing areas that violate the setup / teardown guideline: https://github.com/mozilla-mobile/firefox-ios/wiki/Unit-Tests-Guidelines#1-setupteardown

:information_source: Reference Person

@cyndichin

┆Issue is synchronized with this Jira Task

[iSoliman]

hey, I would like to work on this.

[cyndichin]

thank you for your interest @iSoliman, unfortunately there's already a PR open to address this work. We have other unit test issues if interested and there will be future good first issues as well.

[FilippoZazzeroni]

Hi @iSoliman we had to close the PR for this issue, so feel free to take on if you want.

[chickenwaddle77]

Hi, I would like to work on this issue. Thanks

[FilippoZazzeroni]

Hi @chickenwaddle77 yes sure thanks so much, i'm assigning you to this task