Bugfix FXIOS-9839 Fix broken navigation when current tab location is homepage (backport #21641)

[mergify[bot]]

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Fixes an issue where the back/forward arrows would be disabled incorrectly after launch if the current tab was on the homepage.

Note

This removes a very old/longstanding logical check that was skipping session data restore if the current tab was on the homepage. I reached out to the team to find out the historical context, as well as if anyone had concerns about this; the feedback I received was that it should be safe to remove. I did a quick round of regression-testing and couldn't identify any issues.

:pencil: Checklist

You have to check all boxes before merging

• [x] Filled in the above information (tickets numbers and description of your work)
• [x] Updated the PR name to follow our PR naming guidelines
• [x] Wrote unit tests and/or ensured the tests suite is passing
• [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• [ ] If needed, I updated documentation / comments for complex code and public methods
• [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

---

This is an automatic backport of pull request #21641 done by [Mergify](https://mergify.com).

[mattreaganmozilla]

cc @DonalMe Fix backported to 130 (for the 130.1 weekly release), per Andy. Please let me know if any questions. Thank you.

[mobiletest-ci-bot]

	Messages
:book:	Project coverage: 32.03%
:book:	Edited 1 files
:book:	Created 0 files

Client.app: Coverage: 30.72

File	Coverage
TabManagerImplementation.swift	30.76%	⚠️

Generated by :no_entry_sign: Danger Swift against 90c881cf70e9e4b70b781bcc53d1a45572cfff6a

[isabelrios]

We may need this fix to land in v130 too: https://github.com/mozilla-mobile/firefox-ios/pull/21817

[pascalchevrel]

We may need this fix to land in v130 too: #21817

@isabelrios is this required because of the failing tests here?

[pascalchevrel]

@mattreaganmozilla Could you look at the failures on the backport? This is currently the only PR targeting the 130 weekly release, if the failures are not straightforward to fix and this is not business-critical to ship a weekly release this week, we can skip this week release.

[isabelrios]

We may need this fix to land in v130 too: #21817

@isabelrios is this required because of the failing tests here?

I think so, we had to backport that fix to 131, I am not sure if the change that caused that error was uplifted to 130 too.. checking...

[isabelrios]

We may need this fix to land in v130 too: #21817

@isabelrios is this required because of the failing tests here?

I think so, we had to backport that fix to 131, I am not sure if the change that caused that error was uplifted to 130 too.. checking...

The fix was added due to changes in this PR, can't see if the failure is exactly the same.. running the test in this branch to try to give more info

[isabelrios]

✅