firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-9198 enhanced tracking protection details screen

Open petruSt24 opened this issue 1 year ago • 2 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Added the tracking protection details view setup, will add the actions in a separate PR to keep them smaller. Also modified the LinkButton to accept different underlineStyles in case the design will require so, like the View certificates button in this screen.

:pencil: Checklist

You have to check all boxes before merging

  • [X] Filled in the above information (tickets numbers and description of your work)
  • [X] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [X] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

petruSt24 avatar Aug 14 '24 10:08 petruSt24

This pull request has conflicts when rebasing. Could you fix it @petruSt24? 🙏

mergify[bot] avatar Aug 20 '24 18:08 mergify[bot]

Simulator Screenshot - iPhone 15 Pro - 2024-08-20 at 19 50 39 Simulator Screenshot - iPhone 15 Pro - 2024-08-20 at 20 32 16 Used the .pageSheet presentation to work on the design, will look like in figma once the navigation controller is added

petruSt24 avatar Aug 20 '24 18:08 petruSt24

Messages
:book: Project coverage: 31.47%
:book: Edited 6 files
:book: Created 4 files

Client.app: Coverage: 30.16

File Coverage
TrackingProtectionViewController.swift 28.69% ⚠️
TrackingProtectionDetailsViewController.swift 0.0% ⚠️
TrackingProtectionVerifiedByView.swift 0.0% ⚠️
TrackingProtectionHeaderView.swift 0.0% ⚠️
TrackingProtectionModel.swift 27.66% ⚠️
TrackingProtectionStatusView.swift 0.0% ⚠️

Generated by :no_entry_sign: Danger Swift against 1b7269d0b5c1ed4e2652b79917cdec5e0262ec46

mobiletest-ci-bot avatar Aug 29 '24 15:08 mobiletest-ci-bot