firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Edit option is missing from "Bookmark added" toast message when bookmark is added from tab tray context menu

Open alinamoldovan84 opened this issue 1 year ago • 1 comments

Steps to reproduce

  1. Create a tab and open a web page
  2. Navigate to the tab tray and open the tab's context menu
  3. Choose to bookmark the webpage
  4. Check the toast message

Expected behavior

The edit button is available on the context menu

Actual behavior

The edit button is missing from the context menu

Device & build information

  • Device: iPhone 15+ (17.5.1)
  • Build version: v129 (44146)
  • First seen version: ?

Notes

Attachments:

https://github.com/user-attachments/assets/7f7e4e24-08f9-4520-bff6-55dc0edb15a3

┆Issue is synchronized with this Jira Task

alinamoldovan84 avatar Aug 02 '24 11:08 alinamoldovan84

Hi, I'm looking at implementing this to gain familiarity with the codebase - the TabManager and TabManagerMiddleware seem to be designed to NOT communicate back to the coordinator or homePanelDelegate that triggers the navigation to show/edit bookmarks.

I'm still exploring this codebase, any suggestions on triggering this navigation to show all bookmarks from the context menu?

Excited to contribute to this project!

donalddang avatar Aug 27 '24 00:08 donalddang

➤ Matt P commented:

Michael Verdi is this expected behavior? If we add the “Edit” button, we have to consider what the transition to the “edit bookmark” view would look like as it would be a sheet presented by another sheet.

data-sync-user avatar Feb 19 '25 17:02 data-sync-user

➤ Michael Verdi commented:

This behavior might predate everyone currently on the mobile ux team so I guess that counts as expected. It’s good to note that this interaction exists but it wasn’t something that was in scope for our bookmark work.

data-sync-user avatar Feb 19 '25 19:02 data-sync-user