Mozilla Account sign-in page crashes Firefox
Steps to reproduce
- Open Firefox iOS
- Open hamburger menu and select "Sync and Save Data".
- Tap "Use Email Instead" to sign in.
- Enter an email for an existing account. (My test account is on staging server.)
Expected behavior
For new account
- "Set your password" screen is shown to complete account creation.
For existing account
- User can input the password.
Actual behavior
Firefox crashed after entering an email for an existing account.
Device & build information
- Device: iPhone 15 Simulator
- Build version: July 21
- First seen version: July 7
Notes
Attachments:
https://github.com/user-attachments/assets/1992989d-9a15-400b-89f1-7521156e171d
┆Issue is synchronized with this Jira Task
➤ ih-codes commented:
Clare So I wasn’t able to duplicate this on main (I also tried resetting my sim and cleaning my xcode build).
Does it only crash with a staging server account?
If it’s specific to a staging account, how can I make one of those? 🤔
!Simulator Screen Recording - iPhone 15 - 2024-07-25 at 16.30.18.mp4|width=41.66666666666667%,alt="Simulator Screen Recording - iPhone 15 - 2024-07-25 at 16.30.18.mp4"!
➤ Clare So commented:
ih-codes The issue could be specific to the server. 😌 Here are the steps to run the sync integration test that crashes Firefox ~60% of the time
cd firefox-ios/firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests pipenv install pipenv run pytest test_integration.py::test_sync_bookmark_from_deviceThe test account has been created via a library used by the test automation. If you’d like a demo on how to run the test, please let me know. 🙂
➤ ih-codes commented:
Update: Clare So has made a PR https://github.com/mozilla-mobile/firefox-ios/pull/21309 ( https://github.com/mozilla-mobile/firefox-ios/pull/21309|smart-link ) which may address the issue, and she will continue to monitor.
➤ Clare So commented:
The issue can’t be reproduced under the FullFunctionalTestPlan but is reproducible under SyncIntegrationTestPlan. Let me take a look at the test plan.
➤ Clare So commented:
More detailed (manual) reproduction steps:
- Run one sync integration test on the command line that involves signing in. cd firefox-ios/firefox-ios-tests/Tests/SyncIntegrationTests pipenv run pytest test_integration.py::test_sync_bookmark_from_device
- From the XCodebuild logs, get the credentials. The logs looks like the following:
export FXA_EMAIL="
" export FXA_PASSWORD= - Leave the simulator opened as is.
- Open IntegrationTests.swift on Xcode. Change test plan to “SyncIntegrationTestPlan”.
- Update signInFxAccounts() with the credentials gotten from step 2.
userState.fxaUsername = "
" userState.fxaPassword = " " - Run testFxASyncHistory() (or any tests that calls signInFxAccounts()).
This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!