firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Bugfix FXIOS-9413 Long press Find In Page should pre-populate the iOS16 UIFindInteractor bar

Open ih-codes opened this issue 1 year ago • 1 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

The custom built FindInPageBar had functionality to pre-populate the search field from the long press “Find in page” option when a user highlights text on a webpage. The new UIFindInteractor used to fix FXIOS-8693 did not behave the same. This PR restores that functionality.

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

ih-codes avatar Jun 28 '24 17:06 ih-codes

Messages
:book: Project coverage: 32.0%
:book: Edited 2 files
:book: Created 0 files

Client.app: Coverage: 30.58

File Coverage
BrowserViewController.swift 5.32% ⚠️
BrowserViewController+FindInPage.swift 0.0% ⚠️

Generated by :no_entry_sign: Danger Swift against 4deee19df8ddf3ce8521f8ce8089129064443486

mobiletest-ci-bot avatar Jun 28 '24 17:06 mobiletest-ci-bot