firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Refactor FXIOS-9402 Remove unnecessary UI test calls to dismiss the microsurvey prompt

Open ih-codes opened this issue 1 year ago • 1 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Currently there are some calls to the dismissSurveyPrompt method in the UI tests are not necessary anymore. These calls have been removed.

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [x] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

ih-codes avatar Jun 27 '24 20:06 ih-codes

Warnings
:warning: Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review. Consider using epic branches for work that would affect main.
Messages
:book: Project coverage: 31.98%
:book: Edited 133 files
:book: Created 76 files

Client.app: Coverage: 30.47

File Coverage
BrowserViewController.swift 5.28% ⚠️
MicrosurveySurfaceManager.swift 96.08%
MicrosurveyAction.swift 100.0%
MicrosurveyViewController.swift 70.18%
MicrosurveyMiddleware.swift 100.0%
NavigationToolbarContainerModel.swift 0.0% ⚠️
AddressToolbarContainerModel.swift 35.77% ⚠️
AddressBarState.swift 5.41% ⚠️
NavigationBarState.swift 4.63% ⚠️
ToolbarActionState.swift 0.0% ⚠️
ToolbarState.swift 8.54% ⚠️
ToolbarAction.swift 0.0% ⚠️
AddressListView.swift 0.0% ⚠️
AddressAutofillSettingsView.swift 0.0% ⚠️
MicrosurveyTelemetry.swift 80.0%

libStorage.a: Coverage: 59.55

File Coverage
ZoomLevelStore.swift 96.43%

Generated by :no_entry_sign: Danger Swift against f2779738ba05cab203f007ccf179d07206233fcf

mobiletest-ci-bot avatar Jun 27 '24 20:06 mobiletest-ci-bot

@clarmso Could I trouble you for a review on this? Looks like the automation team needs to approve. Thanks!

ih-codes avatar Jul 09 '24 15:07 ih-codes