firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-9391 Display menu and tabs button for regular horizontal size class

Open thatswinnie opened this issue 1 year ago • 1 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Displays the menu & tabs button for regular horizontal size class and hides the tabs button from top tabs.

Simulator Screenshot - iPad Air 11-inch (M2) - 2024-06-27 at 10 39 07

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

thatswinnie avatar Jun 27 '24 08:06 thatswinnie

Messages
:book: Project coverage: 31.84%
:book: Edited 7 files
:book: Created 1 files

Client.app: Coverage: 30.45

File Coverage
BrowserViewController+TabToolbarDelegate.swift 0.81% ⚠️
BrowserViewController.swift 5.32% ⚠️
TopTabsViewController.swift 0.0% ⚠️
AddressToolbarContainerModel.swift 35.56% ⚠️
BackForwardListViewController.swift 13.15% ⚠️
ToolbarHelper.swift 0.0% ⚠️
ToolbarMiddleware.swift 5.15% ⚠️

Generated by :no_entry_sign: Danger Swift against 0e38d4c2c2716ce79cfc6615699c23e83fd053d1

mobiletest-ci-bot avatar Jun 27 '24 08:06 mobiletest-ci-bot