Refactor FXIOS-8821 - Enabled Swiftlint: for_where

[bmihai23]

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

• Enabled Swiftlint rule for_where for Focus.
• No new lint errors found.

:pencil: Checklist

You have to check all boxes before merging

• [x] Filled in the above information (tickets numbers and description of your work)
• [x] Updated the PR name to follow our PR naming guidelines
• [ ] Wrote unit tests and/or ensured the tests suite is passing
• [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• [ ] If needed, I updated documentation / comments for complex code and public methods
• [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

[bmihai23]

Linting Swift files in current working directory Linting 'ActionViewController.swift' (1/215) Linting 'AppShortcutsTests.swift' (2/215) Linting 'Package.swift' (3/215) Linting 'AppImagesView.swift' (5/215) Linting 'AppColorsView.swift' (4/215) Linting 'AppFontsView.swift' (6/215) Linting 'UIFont+AppFonts.swift' (7/215) Linting 'UIColor+AppColors.swift' (8/215) Linting 'UIImage+AppImages.swift' (9/215) Linting 'Bundle+CurrentBundle.swift' (10/215) Linting 'LicenseListView.swift' (11/215) Linting 'LicenseList.swift' (12/215) Linting 'AsyncImageView.swift' (13/215) Linting 'UIButton+Background.swift' (14/215) Linting 'ImageLoader.swift' (15/215) Linting 'UIScreenExtensions.swift' (16/215) Linting 'UIViewController+Child.swift' (17/215) Linting 'UIImageExtensions.swift' (18/215) Linting 'UIApplication+Orientation.swift' (19/215) Linting 'UIViewExtensions.swift' (20/215) Linting 'FaviIconGenerator.swift' (21/215) Linting 'UILabelExtensions.swift' (22/215) Linting 'UITableView+Dequeue.swift' (23/215) Linting 'UIDeviceExtensions.swift' (24/215) Linting 'PortraitHostingController.swift' (25/215) Linting 'OnboardingEventsHandlerV2.swift' (26/215) Linting 'ToolTipRoute.swift' (27/215) Linting 'OnboardingVersion.swift' (28/215) Linting 'OnboardingEventsHandlerV1.swift' (29/215) Linting 'OnboardingEventsHandling.swift' (30/215) Linting 'Action.swift' (31/215) Linting 'Image+AppImages.swift' (32/215) Linting 'Color+AppColors.swift' (33/215) Linting 'Font+AppFonts.swift' (34/215) Linting 'TooltipTableViewCell.swift' (35/215) Linting 'TooltipViewController.swift' (36/215) Linting 'TooltipView.swift' (37/215) Linting 'GetStartedOnboardingView.swift' (39/215) Linting 'OnboardingSearchWidgetView.swift' (38/215) Linting 'ShowMeHowOnboardingView.swift' (40/215) Linting 'OnboardingView.swift' (41/215) Linting 'DefaultBrowserOnboardingView.swift' (42/215) Linting 'OnboardingViewModel.swift' (44/215) Linting 'OnboardingPreview.swift' (45/215) Linting 'CardBannerView.swift' (43/215) Linting 'OnboardingViewController.swift' (46/215) Linting 'ShortcutViewModel.swift' (47/215) Linting 'ShortcutView.swift' (48/215) Linting 'ShortcutsManager.swift' (49/215) Linting 'Shortcut.swift' (50/215) Linting 'ShortcutsPersister.swift' (51/215) Linting 'Deferred.swift' (52/215) Linting 'LockProtected.swift' (53/215) Linting 'ReadWriteLock.swift' (54/215) Linting 'Settings.swift' (56/215) Linting 'AppInfo.swift' (55/215) Linting 'Utils.swift' (57/215) Linting 'AppConfig.swift' (58/215) Linting 'ActionRequestHandler.swift' (59/215) Linting 'get_supported_locales.swift' (60/215) Linting 'SettingsTableViewToggleCell.swift' (61/215) Linting 'SettingsTableViewAccessoryCell.swift' (62/215) Linting 'SettingsTableViewCell.swift' (63/215) Linting 'AutocompleteSettingViewController.swift' (64/215) Linting 'AddCustomDomainViewController.swift' (65/215) Linting 'SafariInstructionsViewController.swift' (66/215) Linting 'AddSearchEngineViewController.swift' (67/215) Linting 'SearchSettingsViewController.swift' (68/215) Linting 'AutocompleteCustomUrlViewController.swift' (69/215) Linting 'AboutViewController.swift' (70/215) Linting 'SettingsContentViewController.swift' (71/215) Linting 'SettingsViewController.swift' (72/215) Linting 'InstructionsView.swift' (73/215) Linting 'ActionFooterView.swift' (74/215) Linting 'NavigationPath.swift' (75/215) Linting 'BlockerEnabledDetector.swift' (76/215) Linting 'ToggleItem.swift' (77/215) Linting 'TrackingProtectionState.swift' (78/215) Linting 'TrackingProtectionManager.swift' (79/215) Linting 'SecureConnectionStatus.swift' (80/215) Linting 'TrackingProtectionViewController.swift' (81/215) Linting 'TrackingProtectionDelegate.swift' (82/215) Linting 'TrackingHeaderView.swift' (83/215) Linting 'SubtitleCell.swift' (84/215) Linting 'ImageCell.swift' (85/215) Linting 'SwitchTableViewCell.swift' (86/215) Linting 'SheetModalViewController.swift' (87/215) Linting 'BlockerToggle.swift' (88/215) Linting 'TrackingProtectionPageStats.swift' (89/215) Linting 'TipManager.swift' (90/215) Linting 'SheetMetrics.swift' (91/215) Linting 'TipsPageViewController.swift' (92/215) Linting 'TipViewController.swift' (93/215) Linting 'InternalSettingsView.swift' (94/215) Linting 'InternalExperimentsSettingsView.swift' (95/215) Linting 'InternalExperimentDetailView.swift' (96/215) Linting 'InternalOnboardingSettingsView.swift' (97/215) Linting 'InternalTelemetrySettingsView.swift' (98/215) Linting 'ShareTrackersViewController.swift' (99/215) Linting 'InternalCrashReportingSettingsView.swift' (100/215) Linting 'WebEngineRefactorFlagManager.swift' (101/215) Linting 'InternalSettings.swift' (102/215) Linting 'ShortcutsPresenter.swift' (103/215) Linting 'OverlayView.swift' (104/215) Linting 'StringExtensions.swift' (105/215) Linting 'CharacterSetExtensions.swift' (106/215) Linting 'FileManagerExtensions.swift' (107/215) Linting 'URLExtensions.swift' (108/215) Linting 'HomeViewController.swift' (109/215) Linting 'ClosedRangeExtensions.swift' (110/215) Linting 'UIPasteBoardExtensions.swift' (111/215) Linting 'SearchSuggestionsPromptView.swift' (112/215) Linting 'OpenSearchParser.swift' (113/215) Linting 'SearchEngine.swift' (114/215) Linting 'AutocompleteTextField.swift' (115/215) Linting 'ShortcutView+UIContextMenuInteractionDelegate.swift' (116/215) Linting 'GradientBackgroundView.swift' (117/215) Linting 'SearchEngineManager.swift' (118/215) Linting 'URLBar.swift' (119/215) Linting 'URLBarDelegate.swift' (120/215) Linting 'UIConstants.swift' (121/215) Linting 'Combine+UIControl.swift' (122/215) Linting 'URLBarViewModel.swift' (123/215) Linting 'BrowserToolbar.swift' (124/215) Linting 'GradientProgressBar.swift' (125/215) Linting 'UIAlertController+Rename.swift' (126/215) Linting 'SmartLabel.swift' (127/215) Linting 'ErrorPage.swift' (128/215) Linting 'InsetButton.swift' (129/215) Linting 'SplashViewController.swift' (130/215) Linting 'Toast.swift' (131/215) Linting 'WebCacheUtils.swift' (132/215) Linting 'UserDefault.swift' (133/215) Linting 'EditView.swift' (134/215) Linting 'FindInPageBar.swift' (135/215) Linting 'SearchHistoryUtils.swift' (136/215) Linting 'Metadata.swift' (137/215) Linting 'AuthenticationManager.swift' (138/215) Linting 'LocalContentBlocker.swift' (139/215) Linting 'TitleActivityItemProvider.swift' (140/215) Linting 'SearchSuggestClient.swift' (141/215) Linting 'HomeViewToolbar.swift' (142/215) Linting 'AdsTelemetryHelper.swift' (143/215) Linting 'OpenUtils.swift' (144/215) Linting 'SupportUtils.swift' (145/215) Linting 'TelemetryIntegration.swift' (146/215) Linting 'OnboardingTelemetryHelper.swift' (147/215) Linting 'KeyboardType.swift' (148/215) Linting 'SearchInContentTelemetry.swift' (149/215) Linting 'InternalURL.swift' (150/215) Linting 'KeyboardHelper.swift' (151/215) Linting 'NimbusExtensions.swift' (152/215) Linting 'Debouncer.swift' (153/215) Linting 'SystemThemeDelegate.swift' (155/215) Linting 'URIFixup.swift' (156/215) Linting 'ThemeTableViewToggleCell.swift' (157/215) Linting 'ThemeViewController.swift' (154/215) Linting 'NimbusWrapper.swift' (158/215) Linting 'MenuAction.swift' (159/215) Linting 'PhotonActionSheet.swift' (160/215) Linting 'Theme.swift' (161/215) Linting 'PhotonActionSheetCell.swift' (162/215) Linting 'UIAction+MenuAction.swift' (163/215) Linting 'WebMenuAction.swift' (164/215) Linting 'PhotonActionSheetItem+MenuAction.swift' (165/215) Linting 'MenuActionable.swift' (167/215) Linting 'ThemeTableViewAccessoryCell.swift' (166/215) Linting 'TrackingProtection.swift' (168/215) Linting 'MenuItemProvider.swift' (169/215) Linting 'PaddedSwitch.swift' (170/215) Linting 'DomainCompletion+ErrorMessage.swift' (171/215) Linting 'DomainCompletion.swift' (172/215) Linting 'InsetTextField.swift' (173/215) Linting 'SiriFavoriteViewController.swift' (174/215) Linting 'SiriShortcuts.swift' (175/215) Linting 'AppDelegate.swift' (176/215) Linting 'LegacyWebViewController.swift' (177/215) Linting 'SectionItem.swift' (178/215) Linting 'DataSource.swift' (179/215) Linting 'OnboardingConstants.swift' (180/215) Linting 'OnboardingFactory.swift' (181/215) Linting 'AsianLocaleTest.swift' (182/215) Linting 'URLValidationTest.swift' (183/215) Linting 'TrackingProtectionTest.swift' (184/215) Linting 'SearchSuggestionsTest.swift' (185/215) Linting 'BaseTestCase.swift' (186/215) Linting 'BrowsingTest.swift' (187/215) Linting 'DragAndDropTest.swift' (188/215) Linting 'SearchProviderTest.swift' (189/215) Linting 'PageActionMenuTest.swift' (190/215) Linting 'CopyPasteTest.swift' (191/215) Linting 'XCUIApplication+Buttons.swift' (192/215) Linting 'TestHelpers.swift' (193/215) Linting 'PageShortcutsTest.swift' (194/215) Linting 'OnboardingTest.swift' (195/215) Linting 'SettingTest.swift' (196/215) Linting 'URIFixupTests.swift' (197/215) Linting 'BrowserViewControllerTests.swift' (198/215) Linting 'URLExtensionsTests.swift' (199/215) Linting 'SupportUtilsTest.swift' (200/215) Linting 'NavigationPathTests.swift' (201/215) Linting 'RequestHandlerTests.swift' (202/215) Linting 'DomainCompletionTests.swift' (203/215) Linting 'SearchEngineTests.swift' (204/215) Linting 'TrackingAdsTests.swift' (205/215) Linting 'SnapshotHelper.swift' (206/215) Linting 'SearchEngineManagerTests.swift' (207/215) Linting 'MarketingTests.swift' (208/215) Linting 'BaseTestCaseL10n.swift' (209/215) Linting 'SnapshotTests.swift' (210/215) Linting 'IntentHandler.swift' (211/215) Linting 'SearchWidgetView.swift' (212/215) Linting 'Widgets.swift' (213/215) Linting 'BrowserViewController.swift' (214/215) Linting 'RequestHandler.swift' (215/215) Done linting! Found 0 violations, 0 serious in 215 files.

[mobiletest-ci-bot]

	Messages
:book:	Edited 8 files
:book:	Created 0 files

Generated by :no_entry_sign: Danger Swift against 9143fd00790d3cbac8c74ea2a2badf25bee55c0e