firefox-ios
firefox-ios copied to clipboard
Refactor FXIOS-8968 - Update Fonts related to Accessory view to use FXFontStyles
:scroll: Tickets
:bulb: Description
- This PR updates the font styles used in AccessoryViewProvider, TPAccessoryInfo, and AutofillAccessoryViewButtonItem classes to improve consistency and adaptability to dynamic font sizes.
AccessoryViewProvider - Before
| Portrait | Landscape |
|---|---|
AccessoryViewProvider - After
| Portrait | Landscape |
|---|---|
TPAccessoryInfo - Before
| Portrait | Landscape |
|---|---|
TPAccessoryInfo - After
| Portrait | Landscape |
|---|---|
AutofillAccessoryViewButtonItem - Before
| Portrait | Landscape |
|---|---|
AutofillAccessoryViewButtonItem - After
| Portrait | Landscape |
|---|---|
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120)
@cwzilla heya, just asking you to verify UI looks!
Hi @bmihai23, thank you for the screenshots!
Just 2 small changes I noticed:
- For
TPAccessoryInfo, should we update 'BLOCKS' heading use the bold style? - For
AutofillAccessoryViewButtonItem, can we update the 'Use saved card' font to the bold style as well?
Thank you!
Hi @bmihai23, thank you for the screenshots!
Just 2 small changes I noticed:
- For
TPAccessoryInfo, should we update 'BLOCKS' heading use the bold style?- For
AutofillAccessoryViewButtonItem, can we update the 'Use saved card' font to the bold style as well?Thank you!
Hi @cwzilla, thanks for the heads up, I just updated the code to use bold instead of regular text style and also updated the screenshots. Please let me know if should I change anything else, thanks again
Hi @bmihai23, thank you for the screenshots! Just 2 small changes I noticed:
- For
TPAccessoryInfo, should we update 'BLOCKS' heading use the bold style?- For
AutofillAccessoryViewButtonItem, can we update the 'Use saved card' font to the bold style as well?Thank you!
Hi @cwzilla, thanks for the heads up, I just updated the code to use bold instead of regular text style and also updated the screenshots. Please let me know if should I change anything else, thanks again
Thanks for the changes! Looks good :)
| Messages | |
|---|---|
| :book: | Project coverage: 31.8% |
| :book: | Edited 3 files |
| :book: | Created 0 files |
Client.app: Coverage: 30.4
| File | Coverage | |
|---|---|---|
| AutofillAccessoryViewButtonItem.swift | 89.01% | ✅ |
| AccessoryViewProvider.swift | 72.02% | ✅ |
| TPAccessoryInfo.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against 49445bfb5ddc5e3ca8d9782bff3164f8c72a5ee7
Heya @bmihai23. Can you rebase against main, please. There was an issue that was causing the build pipeline to fail. It's been fixed, however. Let's get that in here, get it passed, and then merge this PR. :)
Heya @bmihai23. Can you rebase against
main, please. There was an issue that was causing the build pipeline to fail. It's been fixed, however. Let's get that in here, get it passed, and then merge this PR. :)
Ola @adudenamedruby, thanks for the heads up. I just merged the main branch into this one, let me know if I need to do anything else. Thank you