firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-9177 Add remove address feature

Open razvanlitianu opened this issue 1 year ago • 3 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Create remove feature for existing addresses.

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [x] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] ~~When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)~~
  • [ ] ~~If needed, I updated documentation / comments for complex code and public methods~~
  • [ ] ~~If needed, added a backport comment (example @Mergifyio backport release/v120)~~

razvanlitianu avatar Jun 25 '24 08:06 razvanlitianu

Messages
:book: Project coverage: 31.9%
:book: Edited 7 files
:book: Created 1 files

Client.app: Coverage: 30.54

File Coverage
AddressListViewModel.swift 60.48%
RemoveAddressButton.swift 0.0% ⚠️
AddressListView.swift 0.0% ⚠️
EditAddressViewController.swift 0.0% ⚠️

libStorage.a: Coverage: 57.62

File Coverage
RustAutofill.swift 68.31%

Generated by :no_entry_sign: Danger Swift against c5053760e832d972d07d05279a37d19336d681ae

mobiletest-ci-bot avatar Jun 25 '24 11:06 mobiletest-ci-bot

Added do not merge until the strings are in https://github.com/mozilla-mobile/firefox-ios/pull/20813

razvanlitianu avatar Jun 27 '24 08:06 razvanlitianu

This pull request has conflicts when rebasing. Could you fix it @razvanlitianu? 🙏

mergify[bot] avatar Jun 28 '24 06:06 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @razvanlitianu? 🙏

mergify[bot] avatar Jul 01 '24 08:07 mergify[bot]