firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Refactor FXIOS-9384 - Update Fonts related to LabelButtonHeaderView to use FXFontStyles

Open bmihai23 opened this issue 1 year ago • 2 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

  • This PR updates the font style used in the LabelButtonHeaderView class to improve consistency and adaptability to dynamic font sizes.

Before

Light Theme   Dark Theme
Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 52 07 Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 52 16

After

Light Theme   Dark Theme
Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 55 18 Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 55 26

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

bmihai23 avatar Jun 24 '24 22:06 bmihai23

@cwzilla for visibility; slight change from bold to semibold due to following the design system

cyndichin avatar Jun 25 '24 12:06 cyndichin

Messages
:book: Project coverage: 31.89%
:book: Edited 1 files
:book: Created 0 files

Client.app: Coverage: 30.5

File Coverage
LabelButtonHeaderView.swift 2.88% ⚠️

Generated by :no_entry_sign: Danger Swift against decc8a74d3602feb06b940f054c8a1ebcda11bc1

mobiletest-ci-bot avatar Jun 25 '24 17:06 mobiletest-ci-bot

Thanks for the screenshot, @bmihai23! Just want to clarify I'm looking at the right thing, what exactly is LabelButtonHeaderView, is that the secondary button?

cwzilla avatar Jul 02 '24 21:07 cwzilla

Thanks for the screenshot, @bmihai23! Just want to clarify I'm looking at the right thing, what exactly is LabelButtonHeaderView, is that the secondary button?

@cwzilla It's the home page header Though-Provoking Stories

cyndichin avatar Jul 03 '24 12:07 cyndichin

Hi @cyndichin, @cwzilla, thank you for your reviews and I’m sorry that I didn’t specify which label I modified.

bmihai23 avatar Jul 03 '24 12:07 bmihai23

thank you for the great work @bmihai23, merging this PR.

cyndichin avatar Jul 08 '24 14:07 cyndichin