firefox-ios
firefox-ios copied to clipboard
Refactor FXIOS-9384 - Update Fonts related to LabelButtonHeaderView to use FXFontStyles
:scroll: Tickets
:bulb: Description
- This PR updates the font style used in the LabelButtonHeaderView class to improve consistency and adaptability to dynamic font sizes.
Before
| Light Theme | Dark Theme |
|---|---|
After
| Light Theme | Dark Theme |
|---|---|
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120)
@cwzilla for visibility; slight change from bold to semibold due to following the design system
| Messages | |
|---|---|
| :book: | Project coverage: 31.89% |
| :book: | Edited 1 files |
| :book: | Created 0 files |
Client.app: Coverage: 30.5
| File | Coverage | |
|---|---|---|
| LabelButtonHeaderView.swift | 2.88% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against decc8a74d3602feb06b940f054c8a1ebcda11bc1
Thanks for the screenshot, @bmihai23! Just want to clarify I'm looking at the right thing, what exactly is LabelButtonHeaderView, is that the secondary button?
Thanks for the screenshot, @bmihai23! Just want to clarify I'm looking at the right thing, what exactly is
LabelButtonHeaderView, is that the secondary button?
@cwzilla It's the home page header Though-Provoking Stories
Hi @cyndichin, @cwzilla, thank you for your reviews and I’m sorry that I didn’t specify which label I modified.
thank you for the great work @bmihai23, merging this PR.