firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Refactor FXIOS-9383 - Update Fonts related to Onboarding to use FXFontStyles

Open bmihai23 opened this issue 8 months ago • 2 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

  • This PR updates the font styles used in the OnboardingCardViewController class to improve consistency and adaptability to dynamic font sizes.

iPhone 15 Pro - Before

Light Theme   Dark Theme
Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 37 20 Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 37 51

iPhone 15 Pro - After

Light Theme   Dark Theme
Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 39 24 Simulator Screenshot - iPhone 15 Pro - 2024-06-25 at 00 39 33

iPhone SE (2nd generation) - Before

Light Theme   Dark Theme
Simulator Screenshot - iPhone SE (2nd generation) - 2024-06-25 at 19 06 02 Simulator Screenshot - iPhone SE (2nd generation) - 2024-06-25 at 19 06 15

iPhone SE (2nd generation) - After

Light Theme   Dark Theme
Simulator Screenshot - iPhone SE (2nd generation) - 2024-06-25 at 19 06 02 Simulator Screenshot - iPhone SE (2nd generation) - 2024-06-25 at 19 06 15

iPad Pro (M4) - Before

Portrait   Landscape
Simulator Screenshot - iPad Pro 11-inch (M4) - 2024-06-25 at 19 15 27 Simulator Screenshot - iPad Pro 11-inch (M4) - 2024-06-25 at 19 15 32

iPad Pro (M4) - After

Portrait   Landscape
Simulator Screenshot - iPad Pro 11-inch (M4) - 2024-06-25 at 19 15 27 Simulator Screenshot - iPad Pro 11-inch (M4) - 2024-06-25 at 19 15 32

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

bmihai23 avatar Jun 24 '24 21:06 bmihai23