firefox-ios
firefox-ios copied to clipboard
Add FXIOS-9109 [Component Library] Disabled state for primary button
:scroll: Tickets
:bulb: Description
Update our component PrimaryRoundedButton
to update its color based on its disabled state.
Added two new tokens actionPrimaryDisabled
and textInvertedDisabled
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120
)
Screenshots
Dark | Light |
---|---|
@isabelrios @clarmso it seems that Deploy Docc step always fails on individual PRs, but when I check the history it passes when merged into main. Is this something you have more context on? It seems we can merge regardless.
Messages | |
---|---|
:book: | Edited 6 files |
:book: | Created 0 files |
Generated by :no_entry_sign: Danger Swift against bc6b676eccb977fa0bfec482f978524b8ccf6456
@isabelrios @clarmso it seems that Deploy Docc step always fails on individual PRs, but when I check the history it passes when merged into main. Is this something you have more context on? It seems we can merge regardless.
I'm not really familiar with that step, not sure who owns / maintains it. I can take a look to try to fix it while we ask about the owner and what is the expected / the reason of that step... Luckily, that does not block PR to be merged...
thanks for reviewing @nbhasin2!