firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-9056 - Add configuration to toolbar button to render text inside image

Open PARAIPAN9 opened this issue 1 year ago • 2 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

  • This PR adds the TabNumberButton class, responsible for displaying the number of open tabs. Currently in draft status because the animation has not yet been added.
Normal Highlighted
normal highlighted

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

PARAIPAN9 avatar May 09 '24 11:05 PARAIPAN9

Please use latest changes in main to have your PR running. Thanks!

isabelrios avatar May 09 '24 11:05 isabelrios

Warnings
:warning: Variable 'crossCircleFill' in Medium is out of alphabetical order.
:warning: Variable 'cross' in Medium is out of alphabetical order.
Messages
:book: Edited 4 files
:book: Created 3 files

Generated by :no_entry_sign: Danger Swift against 90794a66ffa9225af08209276f351fe700028af5

mobiletest-ci-bot avatar May 09 '24 14:05 mobiletest-ci-bot

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

mergify[bot] avatar May 13 '24 14:05 mergify[bot]