firefox-ios
firefox-ios copied to clipboard
Add FXIOS-9027 Integrate address toolbar in Client
:scroll: Tickets
:bulb: Description
This integrates the navigation toolbar with dummy buttons - only the home button works so far.
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120)
This pull request has conflicts when rebasing. Could you fix it @thatswinnie? 🙏
| Warnings | |
|---|---|
| :warning: | Variable 'crossCircleFill' in Medium is out of alphabetical order. |
| :warning: | Variable 'cross' in Medium is out of alphabetical order. |
| Messages | |
|---|---|
| :book: | Project coverage: 32.58% |
| :book: | Edited 11 files |
| :book: | Created 7 files |
Client.app: Coverage: 31.11
| File | Coverage | |
|---|---|---|
| BrowserViewController+TabToolbarDelegate.swift | 11.66% | ⚠️ |
| GeneralBrowserAction.swift | 0.0% | ⚠️ |
| BrowserViewController.swift | 4.5% | ⚠️ |
| NavigationToolbarContainer.swift | 0.0% | ⚠️ |
| BrowserViewControllerState.swift | 0.0% | ⚠️ |
| AppState.swift | 89.66% | ✅ |
| ToolbarFlagManager.swift | 0.0% | ⚠️ |
| ToolbarState.swift | 0.0% | ⚠️ |
| ToolbarAction.swift | 0.0% | ⚠️ |
| NimbusFlaggableFeature.swift | 97.78% | ✅ |
| NimbusFeatureFlagLayer.swift | 73.49% | ✅ |
| ToolbarMiddleware.swift | 11.76% | ⚠️ |
| NavigationToolbarContainerModel.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against 6b32cba8a785de5ac1524d0cd0e84203bbf51240