firefox-ios
firefox-ios copied to clipboard
[WIP] Add FXIOS-8988 [Microsurvey] Redux architecture
:scroll: Tickets
:bulb: Description
Setup Redux architecture to handle state for microsurvey prompt. Draft PR to discuss with Orla in how we envision our architecture to be going forward and to see microsurveys as an example.
Handles
- initializing / showing prompt
- dismissing prompt when tapping on close button
- print out text to open survey when tapping on continue button
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [ ] Wrote unit tests and/or ensured the tests suite is passing
- [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
- [ ] If needed, I updated documentation / comments for complex code and public methods
- [ ] If needed, added a backport comment (example
@Mergifyio backport release/v120
)
Warnings | |
---|---|
:warning: | Variable 'crossCircleFill' in Medium is out of alphabetical order. |
:warning: | Variable 'cross' in Medium is out of alphabetical order. |
Messages | |
---|---|
:book: | Project coverage: 32.53% |
:book: | Edited 6 files |
:book: | Created 4 files |
Client.app: Coverage: 31.14
File | Coverage | |
---|---|---|
MicrosurveyPromptState.swift | 86.96% | ✅ |
BrowserViewController.swift | 4.48% | ⚠️ |
MicrosurveyPromptAction.swift | 100.0% | ✅ |
MicrosurveyPromptMiddleware.swift | 47.5% | ⚠️ |
MicrosurveyPrompt.swift | 0.0% | ⚠️ |
BrowserViewControllerState.swift | 0.0% | ⚠️ |
AppState.swift | 89.66% | ✅ |
FakespotState.swift | 13.67% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against b19f69c9b84f738f9df24d2da48ec482f7736469
This pull request has conflicts when rebasing. Could you fix it @cyndichin? 🙏