firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-9042 - Add optional badge to ToolbarElement/ToolbarButton

Open PARAIPAN9 opened this issue 9 months ago • 2 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Example

demo

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed, I updated documentation / comments for complex code and public methods
  • [ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

PARAIPAN9 avatar Apr 30 '24 08:04 PARAIPAN9

Warnings
:warning: Variable 'crossCircleFill' in Medium is out of alphabetical order.
:warning: Variable 'cross' in Medium is out of alphabetical order.
Messages
:book: Edited 3 files
:book: Created 2 files

Generated by :no_entry_sign: Danger Swift against 9aa4ea65c4e77aa586a6c2552aea5e196d7ff34c

mobiletest-ci-bot avatar Apr 30 '24 08:04 mobiletest-ci-bot

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

mergify[bot] avatar May 07 '24 07:05 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

mergify[bot] avatar May 14 '24 11:05 mergify[bot]

What is left for me to do

Nothing on this PR, @Karma197617. If you'd like to contribute you could look for issues here and please make sure to read through our contributing wiki article 🙏

thatswinnie avatar May 22 '24 13:05 thatswinnie