mozilla-mobile
Wrong coloring of secondary buttons in dark mode
Steps to reproduce
- Set theming to dark from iOS settings, install and open FF.
- Observe the onboarding tour.
- From hamburger menu, go to "sync and save data" and observe.
Expected behavior The secondary buttons in dark mode have black font on light grey background.
Actual behavior The secondary buttons in dark mode have white font on light grey background.
Device & build information
- Device: iPhone 15 (17.4)
- Build version: v125.2 (41035)
- First seen version: ?
Notes Attachments:
┆Issue is synchronized with this Jira Task
➤ Roux Buciu commented:
So, I tested this on main and it’s not reproducible. I also tested on 126.0 (41303) as well as nightly and it’s not reproducible there either.
What I’m pretty sure happened is that when we were doing backports for customization, Matt’s very large theme PR landed, and there were a ton of conflicts between main and 125 backports relating to theme issues. In trying to fix backport conflicts, something there probably got messed up.
Norberto Andres Furlan what’s the priority of fixing this? Do we need a hotfix ? Do we wait till 126 goes out? If we need a hotfix, I can probably figure out what’s happening within a day; but that’s a 125 only fix, not a main fix so we’ll have divergence there.
➤ Norberto Andres Furlan commented:
Andrei Bodea can you tell me the impact of this? What other screens are we impacting? We are two weeks to 126, so it is a lot of time if this is affecting all secondary buttons.
➤ Andrei Bodea commented:
Hi there, the screens that this issue is reproducible are the same as the attachments: On the onboarding and the Settings>Synchronise and Save Data for use email instead.
v125.2 and v125.3 but not reproducible on v126.
➤ Roux Buciu commented:
Norberto Andres Furlan what’s happening with this ticket? Do I put it in closed?
➤ Roux Buciu commented:
No one has replied here, so, given that the last comment is that it’s not reproducible on 126 or above, I’mma mark it as closed for now.