firefox-ios
firefox-ios copied to clipboard
Update Fonts related to Toasts to use FXFontStyles
This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.
Background Context:
Previously, we were using DefaultDynamicFontHelper
and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles
, we can standardize our fonts and be more aligned with the design system.
Task: Please update how we set fonts related:
ButtonToast
DownloadToast
SimpleToast
Acceptance Criteria:
Replace usage of DefaultDynamicFontHelper
with FXFontStyles
If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.
Please provide before and after screenshots of the UI.
Reference:
Usage example:
FXFontStyles.Regular.headline.scaledFont()
See this PR for example of standardizing fonts for Primary Button:
https://github.com/mozilla-mobile/firefox-ios/pull/18711/files
┆Issue is synchronized with this Jira Task
I will work on this one.
great @tisumi99 !! thank you so much for also providing the screenshots!
@tisumi99 Thank you for all the screenshots! Everything looks good!
➤ Cyndi Chin commented:
Please see screenshots attached to github issue and verify fonts are scaling properly. Thank you!
➤ Diana Andreea Barladeanu commented:
Validated on v9000 (41731), with iPhone 15 (17.4).
➤ Diana Andreea Barladeanu commented:
Validated on v127 (41813), with iPhone 15 (17.4).