firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Update Fonts related to Toasts to use FXFontStyles

Open data-sync-user opened this issue 11 months ago • 6 comments

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context: Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task: Please update how we set fonts related:

ButtonToast DownloadToast SimpleToast

Acceptance Criteria:

Replace usage of DefaultDynamicFontHelper with FXFontStyles

If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.

Please provide before and after screenshots of the UI.

Reference:

Usage example: FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task

data-sync-user avatar Apr 04 '24 18:04 data-sync-user

I will work on this one.

tisumi99 avatar Apr 19 '24 21:04 tisumi99

Screenshot 2024-04-19 at 4 33 15 PM Screenshot 2024-04-19 at 4 34 03 PM Screenshot 2024-04-19 at 4 35 25 PM Screenshot 2024-04-19 at 4 38 09 PM Screenshot 2024-04-19 at 4 36 12 PM Screenshot 2024-04-19 at 4 39 15 PM

tisumi99 avatar Apr 19 '24 23:04 tisumi99

great @tisumi99 !! thank you so much for also providing the screenshots!

cyndichin avatar Apr 22 '24 13:04 cyndichin

@tisumi99 Thank you for all the screenshots! Everything looks good!

cwzilla avatar Apr 22 '24 17:04 cwzilla

➤ Cyndi Chin commented:

Please see screenshots attached to github issue and verify fonts are scaling properly. Thank you!

data-sync-user avatar Apr 22 '24 18:04 data-sync-user

➤ Diana Andreea Barladeanu commented:

Validated on v9000 (41731), with iPhone 15 (17.4).

data-sync-user avatar May 10 '24 14:05 data-sync-user

➤ Diana Andreea Barladeanu commented:

Validated on v127 (41813), with iPhone 15 (17.4).

data-sync-user avatar May 14 '24 07:05 data-sync-user