firefox-ios
firefox-ios copied to clipboard
Update Fonts related to HistoryHighlights to use FXFontStyles
This task is part of a series of tasks to standardizing fonts to start using FXFontStyles
.
Background Context:
Previously, we were using DefaultDynamicFontHelper
and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles
, we can standardize our fonts and be more aligned with the design system.
Task: Please update how we set fonts related:
HistoryHighlightsCell
Acceptance Criteria:
- Replace usage of
DefaultDynamicFontHelper
withFXFontStyles
- If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.
- Please provide before and after screenshots of the UI.
Reference:
Usage example:
FXFontStyles.Regular.headline.scaledFont()
See this PR for example of standardizing fonts for Primary Button:
https://github.com/mozilla-mobile/firefox-ios/pull/18711/files
┆Issue is synchronized with this Jira Task
I will like to pick this issue
thanks @pelumy for the interest, I assigned this issue to you!
Thank you @cyndichin
➤ Cyndi Chin commented:
Please verify that the fonts are scaled properly under the Recently Visited Section. Thank you!
!image-20240409-132432.png|width=567,height=607,alt="image-20240409-132432.png"!
➤ Diana Andreea Barladeanu commented:
Hi Cyndi Chin! Recently visited section is currently disabled, how should we proceed with this ticket? Thanks!
➤ Diana Andreea Barladeanu commented:
Verified as fixed on v127 (41813), with iPhone 15 (17.4).