firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Update Fonts related to HistoryHighlights to use FXFontStyles

Open data-sync-user opened this issue 11 months ago • 5 comments

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context: Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task: Please update how we set fonts related:

HistoryHighlightsCell

Acceptance Criteria:

  • Replace usage of DefaultDynamicFontHelper with FXFontStyles
  • If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.
  • Please provide before and after screenshots of the UI.

Reference:

Usage example: FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task

data-sync-user avatar Mar 21 '24 17:03 data-sync-user

I will like to pick this issue

pelumy avatar Mar 23 '24 13:03 pelumy

thanks @pelumy for the interest, I assigned this issue to you!

cyndichin avatar Mar 25 '24 13:03 cyndichin

Thank you @cyndichin

pelumy avatar Mar 26 '24 10:03 pelumy

➤ Cyndi Chin commented:

Please verify that the fonts are scaled properly under the Recently Visited Section. Thank you!

!image-20240409-132432.png|width=567,height=607,alt="image-20240409-132432.png"!

data-sync-user avatar Apr 09 '24 13:04 data-sync-user

➤ Diana Andreea Barladeanu commented:

Hi Cyndi Chin! Recently visited section is currently disabled, how should we proceed with this ticket? Thanks!

data-sync-user avatar May 10 '24 07:05 data-sync-user

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v127 (41813), with iPhone 15 (17.4).

data-sync-user avatar May 15 '24 07:05 data-sync-user