[Tab tray refactor] Private mode tab tray may not be in private mode (iPad only)

[clarmso]

Steps to reproduce

1. Open tab tray.
2. Toggle to private browsing mode.
3. Tap "+" from the tab tray.
4. Tap "+" near the awesome bar.
5. Open tab tray again.

Expected behavior

"Private" should toggled.

Actual behavior

The tab tray is purple but the regular tab ("[1]") is toggled.

Device & build information

Device: iPad Air (5th generation) iOS 17.2 simulator

• Build version: 9000 - Feb 26, 2024
• First seen version: (After tab tray refactor)

Notes

Attachments: The issue is in iPad only. In automated tests, such a tab tray opens a regular tab (testOpenInNewPrivateTabRecentlyClosedItem)

https://github.com/mozilla-mobile/firefox-ios/assets/1740517/53940e5b-c286-420f-962f-ccf341ddfc7c

┆Issue is synchronized with this Jira Task

[MattLichtenstein]

I understand this is part of a refactor, but would this bug be open to contributors? If so I'd love to tackle it 🙂

[clarmso]

I understand this is part of a refactor, but would this bug be open to contributors? If so I'd love to tackle it 🙂

@MattLichtenstein Please feel free to reach out to us via Matrix. I suspect this bug could be a symptom or a duplicate of something else that has been opened. I'll let the team to triage this bug.

[data-sync-user]

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (41731), with iPad Air 3rd gen (17.5).

!RPReplay_Final1715494641.mp4|width=720,height=960,alt="RPReplay_Final1715494641.mp4"!

[data-sync-user]

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v126.1 (41973), with iPad Air 3rd gen (17.5).