Bugfix FXIOS-18440 [v125] crash fix if title string is empty

[imsanchit]

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

:pencil: Checklist

You have to check all boxes before merging

• [x] Filled in the above information (tickets numbers and description of your work)
• [x] Updated the PR name to follow our PR naming guidelines
• [ ] Wrote unit tests and/or ensured the tests suite is passing
• [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• [ ] If needed I updated documentation / comments for complex code and public methods

[lmarceau]

@dnarcese @afurlan-firefox This fixes a crash happening in the passwords area. We're not sure what's the ideal use case here. The crash apparently happens if a Login was saved without a title. This use case should in theory not happen. When we retrieve that login and there is no title; should the Login still show without a title or should we hide this Login (the present solution)?

[dnarcese]

I think it should still show, so we can avoid any apparent data loss to the user

[imsanchit]

Thanks, @dnarcese, updated the PR with a possible crash fix + showing all list items as well.

[mobiletest-ci-bot]

	Messages
:book:	Project coverage: 33.49%
:book:	Edited 1 files
:book:	Created 0 files

Client.app: Coverage: 32.24

File	Coverage
PasswordManagerDataSourceHelper.swift	96.1%	✅

Generated by :no_entry_sign: Danger Swift against 6b7b771354b7c884be8042484e2d98167d2bf0ed

[lmarceau]

Thank you @imsanchit 🙏