firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Loading pages leaves the search bar on the screen.

Open jrmuizel opened this issue 1 year ago • 8 comments

Steps to reproduce

  • Tap on the url bar
  • Tap on one of the favicons (like the one for the Toronto Star)

See

https://github.com/mozilla-mobile/firefox-ios/assets/332653/886e812f-e84f-40d4-96df-785f8e7f69f3

Expected behavior

The new page should load, the keyboard should go away and the url bar should have a url for the current page.

Actual behavior

The new page loads, the keyboard stays up and url bar has the url for the previous page.

Device & build information

  • Device: 14 Mini
  • Build version: ? 122.2
  • First seen version: ? Recently

Notes

This seems to only happen when in the control group of "We should prefer switching to open tabs vs..." experiment.

Attachments:

┆Issue is synchronized with this Jira Task

jrmuizel avatar Feb 13 '24 19:02 jrmuizel

➤ Norberto Andres Furlan commented:

Diana Andreea Barladeanu Andrei Bodea can you reproduce it? How often is happening? Thanks!

data-sync-user avatar Feb 13 '24 19:02 data-sync-user

@jrmuizel can you confirm you iOS version? I am not able to reproduce. Thanks!

afurlan-firefox avatar Feb 13 '24 19:02 afurlan-firefox

I'm on an iPhone 13 mini (not 14 mini like I wrote) on iOS 17.2.1

jrmuizel avatar Feb 13 '24 19:02 jrmuizel

@jrmuizel can you confirm you iOS version? I am not able to reproduce. Thanks!

Did you confirm that you were in the control group of the experiment?

jrmuizel avatar Feb 13 '24 19:02 jrmuizel

➤ Norberto Andres Furlan commented:

Yes, I am. I was able to repro, but it only happens to me if I stay on the same page (I am in the tab “google.com ( http://google.com )” and I click on the top site “google.com ( http://google.com )”). If I switch to other top site, it hides the keyboard and unfocus the URL bar.

[^RPReplay_Final1707855106.MP4]

[^RPReplay_Final1707855176.MP4]

data-sync-user avatar Feb 13 '24 20:02 data-sync-user

Perhaps you need to have an existing tab that's being replaced for it to reproduce?

jrmuizel avatar Feb 13 '24 20:02 jrmuizel

➤ Norberto Andres Furlan commented:

You are right! Thanks.

data-sync-user avatar Feb 13 '24 21:02 data-sync-user

Yes this seems to be the case. To reproduce make sure you have a tab that's already open for the same page.

e.g. if I have two tabs

  • news.ycombinator.com
  • thestar.com

I switch to the news.ycombinator.com tab and then click on the icon for the thestar.com

jrmuizel avatar Feb 13 '24 21:02 jrmuizel

➤ Norberto Andres Furlan commented:

Fixed on FX 123

data-sync-user avatar Feb 20 '24 15:02 data-sync-user

What change fixed it?

jrmuizel avatar Feb 20 '24 15:02 jrmuizel

hey @jrmuizel https://github.com/mozilla-mobile/firefox-ios/pull/18140 this is the fix

razvanlitianu avatar Feb 20 '24 15:02 razvanlitianu