firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Refactor FXIOS-8428 [v125] Use single name feild for addresses

Open issammani opened this issue 1 year ago • 2 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

This PR (is):

  • Updates address types to have a single name field instead of 3 *-name fields
  • Blocked by this PR https://github.com/mozilla/application-services/pull/6118 in a-s

ℹ️ Note: I built the a-s change locally and all tests related to addresses are passing

Screenshot 2024-02-13 at 15 05 04

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [x] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] ~When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)~
  • [ ] ~If needed I updated documentation / comments for complex code and public methods~

issammani avatar Feb 13 '24 14:02 issammani

@nbhasin2 @jnrahme this change can only be merged after this PR https://github.com/mozilla/application-services/pull/6118 is merged, but a-s recommends to get approval before merging the upstream change.

issammani avatar Feb 13 '24 14:02 issammani

cc @dimidl

issammani avatar Feb 13 '24 15:02 issammani

Messages
:book: Project coverage: 33.46%
:book: Edited 5 files
:book: Created 0 files

Client.app: Coverage: 32.23

File Coverage
AddressCellView.swift 0.0% ⚠️
AddressListViewModel.swift 11.76% ⚠️

Generated by :no_entry_sign: Danger Swift against db332573f878bfe35776bf9c64fc22e92627d265

mobiletest-ci-bot avatar Feb 26 '24 17:02 mobiletest-ci-bot

This is required for https://github.com/mozilla-mobile/firefox-ios/pull/18885

Going to backport

nbhasin2 avatar Feb 28 '24 22:02 nbhasin2

@mergify backport release/v124

nbhasin2 avatar Feb 28 '24 22:02 nbhasin2

backport release/v124

✅ Backports have been created

mergify[bot] avatar Feb 28 '24 22:02 mergify[bot]