Refactor FXIOS-8428 [v125] Use single name feild for addresses
:scroll: Tickets
:bulb: Description
This PR (is):
- Updates address types to have a single
namefield instead of 3*-namefields - Blocked by this PR https://github.com/mozilla/application-services/pull/6118 in a-s
ℹ️ Note: I built the a-s change locally and all tests related to addresses are passing
:pencil: Checklist
You have to check all boxes before merging
- [x] Filled in the above information (tickets numbers and description of your work)
- [x] Updated the PR name to follow our PR naming guidelines
- [x] Wrote unit tests and/or ensured the tests suite is passing
- [ ] ~When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)~
- [ ] ~If needed I updated documentation / comments for complex code and public methods~
@nbhasin2 @jnrahme this change can only be merged after this PR https://github.com/mozilla/application-services/pull/6118 is merged, but a-s recommends to get approval before merging the upstream change.
cc @dimidl
| Messages | |
|---|---|
| :book: | Project coverage: 33.46% |
| :book: | Edited 5 files |
| :book: | Created 0 files |
Client.app: Coverage: 32.23
| File | Coverage | |
|---|---|---|
| AddressCellView.swift | 0.0% | ⚠️ |
| AddressListViewModel.swift | 11.76% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against db332573f878bfe35776bf9c64fc22e92627d265
This is required for https://github.com/mozilla-mobile/firefox-ios/pull/18885
Going to backport
@mergify backport release/v124
backport release/v124
✅ Backports have been created
-
#18922 Refactor FXIOS-8428 [v125] Use single name field for addresses & update SPM with latest rust-component 125.0.20240226160923 (backport #18690) has been created for branch
release/v124but encountered conflicts