firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Add FXIOS-8427 [v124] Add functionality to recognize when an address form is detected and display the address autofill accessory view accordingly.

Open jnrahme opened this issue 1 year ago • 3 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Implement a feature that enables the system to detect when an address form is identified. Upon detection, it triggers an action to display the address autofill accessory view. This ensures that users are provided with autofill suggestions tailored to address fields when filling out forms. To test this work you need to change the following and then navigate to firefox-ios folder on your terminal and run npm run dev
Screenshot 2024-02-12 at 5 16 31 PM

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed I updated documentation / comments for complex code and public methods

jnrahme avatar Feb 12 '24 22:02 jnrahme

This pull request has conflicts when rebasing. Could you fix it @jnrahme? 🙏

mergify[bot] avatar Feb 14 '24 16:02 mergify[bot]

Some minor comments but good to merge after that.

nbhasin2 avatar Feb 15 '24 04:02 nbhasin2

Messages
:book: Project coverage: 33.49%
:book: Edited 6 files
:book: Created 2 files

Client.app: Coverage: 32.29

File Coverage
BrowserViewController.swift 21.15% ⚠️
AccessoryViewProvider.swift 72.02%
FormAutofillHelper.swift 48.54% ⚠️

libStorage.a: Coverage: 59.58

File Coverage
UnencryptedAddressFields.swift 94.74%

Generated by :no_entry_sign: Danger Swift against c9dfd3e090010db1044b0dda56e365e89c1b1f3f

mobiletest-ci-bot avatar Feb 15 '24 21:02 mobiletest-ci-bot

@MergifyIO backport release/v124

jnrahme avatar Feb 27 '24 19:02 jnrahme