firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Refactor FXIOS-8407 [v124] Replace linkButton in FakespotActionFooterView

Open bmihai23 opened this issue 1 year ago • 1 comments

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

  • This PR simplifies the implementation of the FakespotActionFooterView class by refactoring the link button usage.
  • The changes include replacing the previous implementation with a more straightforward approach using the LinkButton class and a LinkButtonViewModel for configuration.

Light Theme

 Before Dropdown  After Dropdown
Simulator Screenshot - iPhone 15 Pro - 2024-02-15 at 17 00 59 Simulator Screenshot - iPhone 15 Pro - 2024-02-15 at 17 01 27

Dark Theme

 Before Dropdown  After Dropdown
Simulator Screenshot - iPhone 15 Pro - 2024-02-15 at 17 01 49 Simulator Screenshot - iPhone 15 Pro - 2024-02-15 at 17 01 55

:pencil: Checklist

You have to check all boxes before merging

  • [x] Filled in the above information (tickets numbers and description of your work)
  • [x] Updated the PR name to follow our PR naming guidelines
  • [ ] Wrote unit tests and/or ensured the tests suite is passing
  • [ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [ ] If needed I updated documentation / comments for complex code and public methods

bmihai23 avatar Feb 08 '24 19:02 bmihai23

Hi @thatswinnie, I wanted to reach out and let you know that I've addressed all the modifications you suggested and I've updated the screenshots to reflect the latest changes accurately.

bmihai23 avatar Feb 15 '24 15:02 bmihai23

Messages
:book: Project coverage: 33.47%
:book: Edited 1 files
:book: Created 0 files

Client.app: Coverage: 32.28

File Coverage
FakespotActionFooterView.swift 0.0% ⚠️

Generated by :no_entry_sign: Danger Swift against 27d1ee0da2a4d9d589f9fc73eeed15107d8199b8

mobiletest-ci-bot avatar Feb 19 '24 09:02 mobiletest-ci-bot

@bmihai23 could you please update your branch with main? The build is failing because your branch is not up-to-date and there are changes on main that are required by the build system to build correctly.

thatswinnie avatar Feb 19 '24 11:02 thatswinnie

@bmihai23 could you please update your branch with main? The build is failing because your branch is not up-to-date and there are changes on main that are required by the build system to build correctly.

Thanks for letting me know, @thatswinnie. I've already merged the main branch into my feature branch, so everything should be up-to-date now. Let me know if you encounter any further issues with the build!

bmihai23 avatar Feb 19 '24 12:02 bmihai23